Exception as event #160
Exception as event #160
Conversation
mikebosland
requested review from
evanweible-wf,
dustinlessard-wf and
a team
as code owners
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
test/unit/mocks.mocks.dart
Outdated
| // Copyright 2021-2022 Workiva. | ||
| // Licensed under the Apache License, Version 2.0. Please see https://github.com/Workiva/opentelemetry-dart/blob/master/LICENSE for more information |
There was a problem hiding this comment.
could you run make format to reattach this comment?
There was a problem hiding this comment.
I tried make format. It added the copyright header to 116 files. Apparently the logic to detect pre-existing copyright headers isn't working... I've restored the header for this file directly.
There was a problem hiding this comment.
make format seems to work as expected on my machine when I checkout master. Is this maybe an OS issue?
|
@mikebosland could you regenerate the mocks? |
Hi, I just went to regenerate the mocks. The only diff was to remove the copyright header, so I suppose they are to date, unless I'm missing something... |
|
@mikebosland I think you will need to merge master and regenerate the mocks to resolve the merge conflicts? |
Remove redundant @Protected annotation on private member. Co-authored-by: Blake Roberts <[email protected]>
As it's possible for Spans to be started with a custom startTime, this commit adds support for ending a span with a custom endTime.
This reverts commit 191e4ab.
…to experimental_api.dart
|
Okay, I think I've merged the master. Running the command to regenerate the mocks just removes the file, but all tests continue to pass. |
|
Tests were passing but analyze was not. Removing the mocks.mocks.dart then fixes the analysis problem. |
|
QA +1 |
|
@Workiva/release-management-p |
rmconsole-wf
added
Merge Requirements Met
RM Ready
and removed
Merge Requirements Unmet
labels
Which problem is this PR solving?
Fix a TODO to correct
recordExceptionas an event instead of attributes directly on the span. See the spec: https://opentelemetry.io/docs/specs/otel/trace/exceptions/Fixes #152 (issue)
Short description of the change
Implement as an event instead of span attributes.
How Has This Been Tested?
Adjusted existing integration test.
Checklist: