-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pub.dev PUB POINTS 100->130 #159
Improve pub.dev PUB POINTS 100->130 #159
Conversation
Compare with current https://pub.dev/packages/opentelemetry/score 10 points for lint/deprecation warnings are not addressed. * Include Apache 2.0 license contents [10pts] * https://github.com/dart-lang/pana is looking for a match against one of its licence files for LICENSE. Compare with the LICENSE files in apache licensed projects. https://pub.dev/packages?sort=points * The NOTICE file appears to serve the purpose of the old contents of the LICENSE file. * Note that these are OpenTelementry traces in the description [10pts] * Add a working example demonstrating tracing including propagation.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
I've reached out to legal on my end about updating the license. I'll get this PR moving after touching base with them. |
@mikebosland could the following attribution be added to the end of the LICENSE file as well as updated in the NOTICE file?
|
Adding this text to the LICENSE file causes the license to not be recognised. This text appears to already be present in the NOTICE. I am not a lawyer, but the opentelemetry-dart repository doesn't actually contain the opentelemetry-proto repository. Instead, opentelemetry-dart contains this file:
I suppose that file is fine under your existing copyright. The user of opentelemetry-dart needs to take positive action to download opentelemetry-proto. A simple |
@mikebosland Okay, I've confirmed with folks on my side, we're good to update the attribution in the notice (from otel js to otel proto) and remove the attribution from the license |
See the .gitmodules file for the authoritative reference.
Okay, I've made the change (I didn't catch the js vs proto difference!) and synced. |
QA +1 docs only |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Compare with current https://pub.dev/packages/opentelemetry/score
10 points for lint/deprecation warnings are not addressed.
Which problem is this PR solving?
This OpenTelemetry dart implementation provides the tools that needed to get tracing working. When users look at packages on pub.dev a major consideration of package health is pub points. The goal of this PR is to increase the pub points to make this package more desirable for newcomers.
Also, the README.md appears to show non-working options. For example
whichContext
doesn't appear to be valid. A example is supported by the compiler and is executable showing example output.Fixes # (issue)
Short description of the change
Change the description, license and add an example to increase pub points to 130/140.
How Has This Been Tested?
Pub point changes where manually evaluated using:
Checklist: