PROD-54189 Fix regex configuration via environment variables

[ChristosLabrou]

When an expected Regex would be passed as a string (which happens when setting regexes via environment variables) then riviere would throw in specific points and not log requests.

[nikostoulas]

@ChristosLabrou why is this happening? I see that orka does the wiring of env vars to regexp. Riviere isn't the place to do this. Is sth missing from here: https://github.com/Workable/orka/blob/master/src/initializers/riviere.ts?

[nikostoulas]

Let's make any needed changes to orka. Riviere is expecting a js object as configuration so passing string where riviere expects a regex makes little sense

[ChristosLabrou]

@ChristosLabrou why is this happening? I see that orka does the wiring of env vars to regexp. Riviere isn't the place to do this. Is sth missing from here: https://github.com/Workable/orka/blob/master/src/initializers/riviere.ts?

This was my initial attempt but didn't work when testing. There is an override for outbound which would override any casting of outbound.blacklistedPathRegex to RegExp instance and convert it back to string. Riviere already has this behavior for headerRegex even with Orka converting to RegExp instance too

[nikostoulas]

@ChristosLabrou why is this happening? I see that orka does the wiring of env vars to regexp. Riviere isn't the place to do this. Is sth missing from here: https://github.com/Workable/orka/blob/master/src/initializers/riviere.ts?

This was my initial attempt but didn't work when testing. There is an override for outbound which would override any casting of outbound.blacklistedPathRegex to RegExp instance and convert it back to string.

That orka is passing configuration wrongly is orka's issue to fix.

Riviere already has this behavior for [headerRegex]
(

riviere/lib/utils.js

Line 20 in 2c25326

if (new RegExp(headersRegex).test(header)) {

) even with Orka converting to RegExp instance too

Possibly leftover from older implementations. Doesn't justify repeating it. (E.g note that in an initial implementation default option was a string here: c9531a1)

[klesgidis]

It is not just orka's issue as far as I understand. When you override the regex from helm release, whatever transformation you do in orka, here you will have a string

cc: @nikostoulas

[nikostoulas]

It is not just orka's issue as far as I understand. When you override the regex from helm release, whatever transformation you do in orka, here you will have a string

cc: @nikostoulas

@klesgidis No. Riviere is initialized with code not from env. So it's the code's responsibility to pass a regex. This code for our apps lies in orka.

[klesgidis]

oh you're right

[ChristosLabrou]

Closing this. Will open PR in Orka instead as discussed