PHP: Replace Worker Threads with Web Workers #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happen to have running Firefox 113, just before ESM module import in workers was supported, because apparently the update to 114 hasn't reached this distribution yet. Checked out the PR branch, and the built static site ( |
Iframe worker threads were introduced as a workaround for limitations in web browsers. Namely: * Chrome crashed when using WASM in web workers * Firefox didn't support ESM workers at all Both problems are now solved: * #1 * mdn/content#26774 There are no more reasons to keep maintaining the iframe worker thread backend. Let's remove it and lean fully on web workers.
adamziel
force-pushed
the
remove-worker-thread-concept
branch
from
80b8386 to
883ba6d
Compare
adamziel
added a commit
to WordPress/playground-tools
that referenced
this pull request
Jun 19, 2023
Adjusts the interactive code block to use the new `spawnPHPWorkerThread()` signature committed in WordPress/wordpress-playground#471 The old signature was `spawnPHPWorkerThread(url, workerType, options)` The new signature is `spawnPHPWorkerThread(url, options)` as WASM in ESM WebWorkers is now correctly supported in all major browser.
sejas
pushed a commit
to WordPress/playground-tools
that referenced
this pull request
Jun 21, 2023
* Adjusts the interactive code block to use the new `spawnPHPWorkerThread()` signature committed in WordPress/wordpress-playground#471 * The old signature was `spawnPHPWorkerThread(url, workerType, options)` * The new signature is `spawnPHPWorkerThread(url, options)` as WASM in ESM WebWorkers is now correctly supported in all major browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Iframe worker threads were introduced as a workaround for limitations in web browsers. Namely:
Both problems are now solved:
There are no more reasons to keep maintaining the iframe worker thread backend. Let's remove it and lean fully on web workers.
Breaking change
This PR changes the signature of
spawnPHPWorkerThreadfromspawnPHPWorkerThread(workerUrl, workerType, options)tospawnPHPWorkerThread(workerUrl, options)and is therefore breaking. The following follow-up PR is required:WordPress/playground-tools#81
cc @eliot-akira