Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onboarding modal to playground #1777

Conversation

n8finch
Copy link
Contributor

@n8finch n8finch commented Sep 17, 2024

Resolves #497

Motivation for the change, related issues

Adds an onboarding modal using the Modal from WordPress Components.

Testing Instructions (or ideally a Blueprint)

  1. Checkout the branch
  2. Run npm run dev
  3. Make sure you've cleared any hideExperimentalNotice cookie from your Application cache
  4. When it initially loads, you should see a modal pop up like the below screenshot.
  5. When you click on the blue "ok" button, it should hide and create a cookie to hide the modal.
image

Feedback

@adamziel I worked on this with @sejas , but wanted to check with you specifically on two pieces:

  1. Do we want the cookie to be implemented "forever", or to expire in a week or month? Current implementation is forever.
  2. Do you have any feedback on the copy? This can definitely say whatever we like, but I'm happy to change it to be whatever you think is appropriate, as well as including or removing emojis 😁.

@n8finch
Copy link
Contributor Author

n8finch commented Sep 19, 2024

Ahh, seeing that the Cypress was failing tests, I updated the website-ui tests and added a URL param check. Looks like things are good now. 🙂

@adamziel
Copy link
Collaborator

👋 Thank you for contributing @n8finch! It pains me to say this – the onboarding modal idea will soon be obsoleted by this work: #1731. It will enable saving Playgrounds, solve the data loss problem, and introduce a sidebar where any required onboarding could happen. We should have closed the original issue earlier, sorry about that!

@adamziel adamziel closed this Sep 23, 2024
@n8finch
Copy link
Contributor Author

n8finch commented Sep 23, 2024

@adamziel haha, no worries at all, it was a good learning experience, good to work with @sejas at the contributor day, and I'm not emotionally attached to code I so it's all good 😁.

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Website: Onboarding modal for new users
2 participants