Serve file as PHP if a static file wasn't found #1203
Conversation
|
Thanks for this @bgrgicak . I am still eager to meet with you on slack. Unfortunately I am out of time to meet with you today. I got behind on marking and need to get caught up. Maybe Wednesday? |
|
@rhildred I can't on Wednesday. Would you mind sending me a DM on Slack and we can find a time there? |
| return await this.#dispatchToPHP(request, requestedUrl); | ||
| if (this.#isStaticFile(fsPath)) { | ||
| return this.#serveStaticFile(fsPath); | ||
| } else if (this.#isStaticWpCoreFile(fsPath)) { |
There was a problem hiding this comment.
We shouldn't have WordPress-specific code in PHP-wasm but I'm not sure how to resolve this.
I think that the best solution would be to catch this in service-worker and not even trigger the request handler.
The problem is that service-worker can't check if the file exists, so we would need to have a list of available core files.
|
@brandonpayton I'm closing this PR because it's probably not relevant anymore after you routing changes. |
Fixes #1186
What is this PR doing?
What problem is it solving?
How is the problem addressed?
Testing Instructions