Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts/Post Types: Introduced the 'item_trashed' default label #4253

Closed
wants to merge 1 commit into from

Conversation

James-Roberts
Copy link

Added the item_trashed default label to the get_default_labels() method.

This update adds the item_trashed default label to the get_default_labels() method. As per #25604 , this should allow #25563 to move forward now that the strings are translatable. Note: #25563 was reverted, pending this update to core.

Testing Instructions:

  1. Manually apply the changes in #25563 to a local copy of the Gutenberg plugin.
  2. Remove the if statement here.
  3. Instead of noticeMessage = ${ postType.labels.singular_name } trashed.;, use noticeMessage = postType.labels.item_trashed;
  4. Re-build Gutenberg - npm run build.
  5. Open a post in the editor - On the Document settings pane, click on "Move to trash".
  6. Voice Over should read "Post trashed" before redirecting.

Trac ticket: https://core.trac.wordpress.org/ticket/51387

Introduced the 'item_trashed' default label in the method get_default_labels().
@github-actions
Copy link

Hi @James-Roberts! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@James-Roberts
Copy link
Author

E2E test locally gives the following results:

Test Suites: 6 passed, 6 total
Tests:       15 passed, 15 total
Snapshots:   0 total
Time:        117.714 s, estimated 224 s

Would it be possible to re-run it?

@WordPress WordPress deleted a comment from github-actions bot Mar 27, 2023
@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r55923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants