Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts: Add custom fonts for WordCamp Asia #1226

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Jan 25, 2024

Fixes #1189

Adopt the method outlined in issue #1216 as a temporary solution for loading custom fonts for WordCamp Asia.
Additionally, removing the 'preview' properties does not affect functionality, so it has been removed as well. (Tested on sandbox)

Screenshots

image
image
Screenshot 2024-01-26 at 03 09 21
Screenshot 2024-01-26 at 03 09 32
Screenshot 2024-01-26 at 03 09 39

How to test the changes in this Pull Request:

  1. Add some text in the editor and use the new fonts, it should render the fonts in either the editor or the frontend.

This is a workaround to load the font files on the site as if they're part of the theme.json's settings.
@renintw renintw self-assigned this Jan 25, 2024
@renintw renintw changed the title Add/wordcamp fonts Fonts: Add load custom fonts for WordCamp Asia Jan 25, 2024
@renintw renintw changed the title Fonts: Add load custom fonts for WordCamp Asia Fonts: Add custom fonts for WordCamp Asia Jan 25, 2024
@renintw renintw merged commit ff552a1 into production Jan 29, 2024
3 checks passed
@renintw renintw deleted the add/wordcamp-fonts branch January 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to add fonts for https://asia.wordcamp.org/2024/
1 participant