This repository has been archived by the owner on Jul 9, 2018. It is now read-only.
Hooks: Fix undefined first argument on consecutive action callbacks #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #85
Related: WordPress/gutenberg#5588
This pull request seeks to resolve an issue where all but the first action callbacks will receive
undefined
first argument. This is caused by an intended simplification of the first argument assignment in thecreateRunHook.js
file. However, this treated actions as the same as filters, thus because most actions do not define a return value, the argument would become unset.Testing instructions:
Verify unit tests pass: