Skip to content
This repository was archived by the owner on Jul 9, 2018. It is now read-only.

fix(scripts): rename script from test-unit to test-unit-js #86

Merged
merged 1 commit into from
Feb 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"create-symlinks": "node ./scripts/create-symlinks.js",
"lerna-bootstrap": "lerna bootstrap --hoist",
"postinstall": "npm-run-all lerna-bootstrap create-symlinks build",
"test": "wp-scripts test-unit",
"test": "wp-scripts test-unit-js",
"test:coverage": "npm run test -- --coverage",
"test:coverage-ci": "npm run test -- --coverage && codecov",
"test:watch": "npm run test -- --watch",
Expand Down
10 changes: 5 additions & 5 deletions packages/scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ This is a CLI and exposes a binary called `wp-scripts` so you can call it direct
```json
{
"scripts": {
"test": "wp-scripts test-unit",
"test:help": "wp-scripts test-unit --help",
"test:watch": "wp-scripts test-unit --watch"
"test": "wp-scripts test-unit-js",
"test:help": "wp-scripts test-unit-js --help",
"test:watch": "wp-scripts test-unit-js --watch"
}
}
```
Expand All @@ -30,11 +30,11 @@ This is how you execute those scripts using the presented setup:

## Available Scripts

### `wp-scripts test-unit`
### `wp-scripts test-unit-js`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should swap the title and alias :)


_Alias_: `wp-scripts test-unit-jest`

Launches the test runner. It uses [Jest](https://facebook.github.io/jest/) behind the scenes and you are able to utilize all of its [CLI options](https://facebook.github.io/jest/docs/en/cli.html). You can also run `./node_modules/.bin/wp-scripts test-unit --help` or `npm run test:help` (if you use `package.json` setup shared above) to view all of the available options.
Launches the test runner. It uses [Jest](https://facebook.github.io/jest/) behind the scenes and you are able to utilize all of its [CLI options](https://facebook.github.io/jest/docs/en/cli.html). You can also run `./node_modules/.bin/wp-scripts test-unit-js --help` or `npm run test:help` (if you use `package.json` setup shared above) to view all of the available options.

## Inspiration

Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/utils/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe( 'utils', () => {
} );

describe( 'spawnScript', () => {
const scriptName = 'test-unit';
const scriptName = 'test-unit-js';

beforeAll( () => {
exitMock.mockImplementation( ( code ) => {
Expand Down