Skip to content
This repository has been archived by the owner on Jul 9, 2018. It is now read-only.

Unapply all spacing exceptions. #35

Merged
merged 2 commits into from
Aug 16, 2017
Merged

Conversation

omarreiss
Copy link
Member

Following up on https://wordpress.slack.com/archives/C5UNMSU4R/p1502804922000226

I think I've got all of them. If merged #7 can be updated to no longer include the array spacing exceptions.

cc @aduth

@omarreiss omarreiss requested a review from ntwb August 15, 2017 14:25
@codecov
Copy link

codecov bot commented Aug 15, 2017

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines          48     48           
  Branches        7      7           
=====================================
  Hits           48     48
Impacted Files Coverage Δ
packages/a11y/src/clear.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2cc1c4...5fd43bd. Read the comment docs.

@omarreiss omarreiss changed the title Unapply all array spacing exceptions. Unapply all spacing exceptions. Aug 15, 2017
@aduth
Copy link
Member

aduth commented Aug 15, 2017

A few missed:

$ npx eslint . --rule 'array-bracket-spacing: [2,"always"]' --rule 'space-in-parens: [2,"always"]' --ignore-pattern '**/node_modules/' --ignore-pattern '**/build*/' --parser-options=ecmaVersion:8 --parser-options=sourceType:module

/Users/andrew/Documents/Code/packages/packages/dom-ready/src/test/index.test.js
  6:36  error  There must be a space inside this paren  space-in-parens

/Users/andrew/Documents/Code/packages/packages/url/src/index.js
  17:18  error  Parsing error: Unexpected token ..

/Users/andrew/Documents/Code/packages/scripts/build.js
   69:24  error  There must be a space inside this paren  space-in-parens
   69:29  error  There must be a space inside this paren  space-in-parens
  113:18  error  There must be a space inside this paren  space-in-parens
  113:40  error  There must be a space inside this paren  space-in-parens
  116:15  error  There must be a space inside this paren  space-in-parens
  116:27  error  There must be a space inside this paren  space-in-parens
  117:18  error  There must be a space inside this paren  space-in-parens
  117:37  error  There must be a space inside this paren  space-in-parens
  118:16  error  There must be a space inside this paren  space-in-parens
  118:27  error  There must be a space inside this paren  space-in-parens
  119:18  error  There must be a space inside this paren  space-in-parens
  119:41  error  There must be a space inside this paren  space-in-parens
  144:21  error  There must be a space inside this paren  space-in-parens
  144:26  error  There must be a space inside this paren  space-in-parens

✖ 16 problems (16 errors, 0 warnings)
  15 errors, 0 warnings potentially fixable with the `--fix` option.

(Unexpected token error caused by non-standard Stage 3 Rest/Spread Properties, otherwise handled by using the babel-eslint parser)

@omarreiss
Copy link
Member Author

Thanks, fixed.

@omarreiss omarreiss merged commit f30f8f9 into master Aug 16, 2017
@omarreiss omarreiss deleted the update/spacing-exception branch August 16, 2017 07:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants