Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #3047
Description
Because we'll move to uvloop in #3011, we can go ahead and replace gevent with it, provided adding gevent back fixes the memory leak we're seeing in production.
Our theory is that gevent's
threading
patch effects the reference asyncio implementation that Python ships with, so replacing it with uvloop could also fix the leak. If it doesn't, but gevent does, then we'll probably need to use a different asyncio runner that uses gevent, likegevent-asyncio
.Testing Instructions
CI should pass. Run the app locally and it should work as usual.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin