Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gevent with uvloop #3048

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Replace gevent with uvloop #3048

merged 1 commit into from
Sep 20, 2023

Conversation

sarayourfriend
Copy link
Collaborator

Fixes

Related to #3047

Description

Because we'll move to uvloop in #3011, we can go ahead and replace gevent with it, provided adding gevent back fixes the memory leak we're seeing in production.

Our theory is that gevent's threading patch effects the reference asyncio implementation that Python ships with, so replacing it with uvloop could also fix the leak. If it doesn't, but gevent does, then we'll probably need to use a different asyncio runner that uses gevent, like gevent-asyncio.

Testing Instructions

CI should pass. Run the app locally and it should work as usual.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧱 stack: api Related to the Django API labels Sep 20, 2023
@sarayourfriend sarayourfriend requested a review from a team as a code owner September 20, 2023 07:19
@sarayourfriend sarayourfriend changed the title Add uvloop Replace gevent with uvloop Sep 20, 2023
@obulat obulat merged commit 8ca4c68 into main Sep 20, 2023
@obulat obulat deleted the add/uvloop branch September 20, 2023 10:49
@AetherUnbound AetherUnbound mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants