-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move automations into their own directory; update README #201
Conversation
"volta": { | ||
"node": "14.19.1" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, but should we use the same version as on the frontend (v16)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so too initially but I think for now it's better to match the version of the actions themselves, which is Node 14. We could update those to 16 potentially, if GitHub supports it!
Moved the justfile back to the root and updated its paths. |
@WordPress/openverse-developers could someone help me with the lint issue in this PR? I'm having a difficult time seeing what the problem is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Very neatly organised.
Co-authored-by: Dhruv Bhanushali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I love it 😄
Fixes
Fixes #196 by @zackkrida
Description
This PR move automation scripts and their config files into a top-level
automations/
directory. This could relate to potentially moving to a monorepo as discussed in #192, but also helps generally separate concerns and clean up the repo.Also adds a readme for the new
automations
folder that includes info about requirements and installing dev dependencies.Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin