Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move automations into their own directory; update README #201

Merged
merged 10 commits into from
Mar 30, 2022

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #196 by @zackkrida

Description

This PR move automation scripts and their config files into a top-level automations/ directory. This could relate to potentially moving to a monorepo as discussed in #192, but also helps generally separate concerns and clean up the repo.

Also adds a readme for the new automations folder that includes info about requirements and installing dev dependencies.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner March 25, 2022 17:07
@zackkrida zackkrida requested review from dhruvkb and stacimc March 25, 2022 17:07
@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 25, 2022
Comment on lines +7 to 9
"volta": {
"node": "14.19.1"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, but should we use the same version as on the frontend (v16)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too initially but I think for now it's better to match the version of the actions themselves, which is Node 14. We could update those to 16 potentially, if GitHub supports it!

@zackkrida
Copy link
Member Author

Moved the justfile back to the root and updated its paths.

@zackkrida zackkrida enabled auto-merge (squash) March 25, 2022 18:26
@zackkrida
Copy link
Member Author

@WordPress/openverse-developers could someone help me with the lint issue in this PR? I'm having a difficult time seeing what the problem is.

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Very neatly organised.

Co-authored-by: Dhruv Bhanushali <[email protected]>
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I love it 😄

@zackkrida zackkrida merged commit 5130502 into main Mar 30, 2022
@zackkrida zackkrida deleted the automations-directory branch March 30, 2022 19:57
dhruvkb added a commit that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move js and python dir into a top-level parent dir
4 participants