Update sources button #1021

obulat · 2023-03-24T14:44:57Z

Fixes

Related to #1020 by @obulat

Description

This PR updates the "Add source" button on the sources page.

Testing Instructions

The sources page should look right. The button should have the updated size.

Checklist

My pull request has a descriptive title (not a vague title like
Update index.md).
My pull request targets the default branch of the repository (main) or
a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible
errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

github-actions · 2023-03-24T14:50:27Z

Size Change: -98 B (0%)

Total Size: 845 kB

Filename	Size	Change
`./frontend/.nuxt/dist/client/app.js`	126 kB	+11 B (0%)
`./frontend/.nuxt/dist/client/pages/sources.js`	1.52 kB	-57 B (-4%)
`./frontend/.nuxt/dist/client/pages/sources.modern.js`	1.52 kB	-57 B (-4%)

ℹ️ View Unchanged

Filename	Size	Change
`./frontend/.nuxt/dist/client/235.js`	273 B	0 B
`./frontend/.nuxt/dist/client/235.modern.js`	278 B	0 B
`./frontend/.nuxt/dist/client/236.js`	1.85 kB	0 B
`./frontend/.nuxt/dist/client/app.modern.js`	118 kB	+8 B (0%)
`./frontend/.nuxt/dist/client/commons/app.js`	90.3 kB	0 B
`./frontend/.nuxt/dist/client/commons/app.modern.js`	78.5 kB	0 B
`./frontend/.nuxt/dist/client/components/loading-icon.js`	752 B	0 B
`./frontend/.nuxt/dist/client/components/loading-icon.modern.js`	757 B	0 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.js`	515 B	0 B
`./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js`	518 B	0 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.js`	5.63 kB	0 B
`./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js`	5.48 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-cell.js`	392 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js`	397 B	0 B
`./frontend/.nuxt/dist/client/components/v-audio-details.js`	2.55 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-details.modern.js`	1.78 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js`	1.02 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js`	1.02 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track.js`	5.26 kB	0 B
`./frontend/.nuxt/dist/client/components/v-audio-track.modern.js`	5.21 kB	0 B
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js`	542 B	0 B
`./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js`	548 B	0 B
`./frontend/.nuxt/dist/client/components/v-bone.js`	689 B	0 B
`./frontend/.nuxt/dist/client/components/v-bone.modern.js`	693 B	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.js`	1.28 kB	0 B
`./frontend/.nuxt/dist/client/components/v-box-layout.modern.js`	1.28 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.js`	1.12 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-link.modern.js`	1.1 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-page.js`	526 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-page.modern.js`	530 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.js`	787 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js`	790 B	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.js`	3.77 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js`	3.59 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-popover.js`	1.23 kB	0 B
`./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js`	4.25 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-button.js`	4 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-button.modern.js`	4.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license.js`	1 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license.modern.js`	1 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js`	9.96 kB	0 B
`./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js`	9.94 kB	0 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.js`	754 B	0 B
`./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js`	758 B	0 B
`./frontend/.nuxt/dist/client/components/v-error-image.js`	1.69 kB	0 B
`./frontend/.nuxt/dist/client/components/v-error-image.modern.js`	1.68 kB	0 B
`./frontend/.nuxt/dist/client/components/v-error-section.js`	372 B	0 B
`./frontend/.nuxt/dist/client/components/v-error-section.modern.js`	376 B	0 B
`./frontend/.nuxt/dist/client/components/v-external-search-form.js`	1.9 kB	0 B
`./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js`	1.89 kB	0 B
`./frontend/.nuxt/dist/client/components/v-external-source-list.js`	888 B	0 B
`./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js`	889 B	0 B
`./frontend/.nuxt/dist/client/components/v-full-layout.js`	1.52 kB	0 B
`./frontend/.nuxt/dist/client/components/v-full-layout.modern.js`	1.52 kB	0 B
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.js`	1.61 kB	0 B
`./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js`	1.62 kB	0 B
`./frontend/.nuxt/dist/client/components/v-home-gallery.js`	5.18 kB	0 B
`./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js`	5.17 kB	0 B
`./frontend/.nuxt/dist/client/components/v-homepage-content.js`	1.76 kB	0 B
`./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js`	1.72 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-carousel.js`	4.73 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js`	4.72 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-cell.js`	1.59 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-cell.modern.js`	1.59 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-details.js`	2.15 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-details.modern.js`	1.41 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-grid.js`	2.67 kB	0 B
`./frontend/.nuxt/dist/client/components/v-image-grid.modern.js`	2.54 kB	0 B
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.js`	526 B	0 B
`./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js`	528 B	0 B
`./frontend/.nuxt/dist/client/components/v-load-more.js`	801 B	0 B
`./frontend/.nuxt/dist/client/components/v-load-more.modern.js`	699 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-license.js`	829 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-license.modern.js`	837 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-reuse.js`	1.62 kB	0 B
`./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js`	1.61 kB	0 B
`./frontend/.nuxt/dist/client/components/v-media-tag.js`	416 B	0 B
`./frontend/.nuxt/dist/client/components/v-media-tag.modern.js`	421 B	0 B
`./frontend/.nuxt/dist/client/components/v-modal.js`	1.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-modal.modern.js`	996 B	0 B
`./frontend/.nuxt/dist/client/components/v-no-results.js`	757 B	0 B
`./frontend/.nuxt/dist/client/components/v-no-results.modern.js`	755 B	0 B
`./frontend/.nuxt/dist/client/components/v-radio.js`	1.54 kB	0 B
`./frontend/.nuxt/dist/client/components/v-radio.modern.js`	1.5 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-audio.js`	1.27 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-audio.modern.js`	1.27 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-images.js`	3.24 kB	0 B
`./frontend/.nuxt/dist/client/components/v-related-images.modern.js`	3.12 kB	0 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.js`	978 B	0 B
`./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js`	980 B	0 B
`./frontend/.nuxt/dist/client/components/v-row-layout.js`	1.7 kB	0 B
`./frontend/.nuxt/dist/client/components/v-row-layout.modern.js`	1.71 kB	0 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.js`	825 B	0 B
`./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js`	830 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-grid.js`	5.72 kB	0 B
`./frontend/.nuxt/dist/client/components/v-search-grid.modern.js`	5.64 kB	0 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.js`	600 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js`	605 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-type-radio.js`	804 B	0 B
`./frontend/.nuxt/dist/client/components/v-search-type-radio.modern.js`	779 B	0 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.js`	300 B	0 B
`./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js`	303 B	0 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js`	1.01 kB	0 B
`./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js`	913 B	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.js`	1.16 kB	0 B
`./frontend/.nuxt/dist/client/components/v-snackbar.modern.js`	1.16 kB	0 B
`./frontend/.nuxt/dist/client/components/v-sources-table.js`	14.9 kB	-2 B (0%)
`./frontend/.nuxt/dist/client/components/v-sources-table.modern.js`	14.9 kB	-1 B (0%)
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.js`	306 B	0 B
`./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js`	311 B	0 B
`./frontend/.nuxt/dist/client/pages/about.js`	1.4 kB	0 B
`./frontend/.nuxt/dist/client/pages/about.modern.js`	1.4 kB	0 B
`./frontend/.nuxt/dist/client/pages/audio/_id/index.js`	5.62 kB	0 B
`./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js`	4.85 kB	0 B
`./frontend/.nuxt/dist/client/pages/external-sources.js`	1.56 kB	0 B
`./frontend/.nuxt/dist/client/pages/external-sources.modern.js`	1.57 kB	0 B
`./frontend/.nuxt/dist/client/pages/feedback.js`	1.34 kB	0 B
`./frontend/.nuxt/dist/client/pages/feedback.modern.js`	1.35 kB	0 B
`./frontend/.nuxt/dist/client/pages/image/_id/index.js`	6 kB	0 B
`./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js`	5.16 kB	0 B
`./frontend/.nuxt/dist/client/pages/image/_id/report.js`	1.27 kB	0 B
`./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js`	4.26 kB	0 B
`./frontend/.nuxt/dist/client/pages/index.js`	7.27 kB	0 B
`./frontend/.nuxt/dist/client/pages/index.modern.js`	7.21 kB	0 B
`./frontend/.nuxt/dist/client/pages/preferences.js`	1.32 kB	0 B
`./frontend/.nuxt/dist/client/pages/preferences.modern.js`	1.32 kB	0 B
`./frontend/.nuxt/dist/client/pages/privacy.js`	1.01 kB	0 B
`./frontend/.nuxt/dist/client/pages/privacy.modern.js`	1.02 kB	0 B
`./frontend/.nuxt/dist/client/pages/search-help.js`	1.6 kB	0 B
`./frontend/.nuxt/dist/client/pages/search-help.modern.js`	1.58 kB	0 B
`./frontend/.nuxt/dist/client/pages/search.js`	2.2 kB	0 B
`./frontend/.nuxt/dist/client/pages/search.modern.js`	2.05 kB	0 B
`./frontend/.nuxt/dist/client/pages/search/audio.js`	3.6 kB	0 B
`./frontend/.nuxt/dist/client/pages/search/audio.modern.js`	3.51 kB	0 B
`./frontend/.nuxt/dist/client/pages/search/image.js`	2.84 kB	0 B
`./frontend/.nuxt/dist/client/pages/search/image.modern.js`	2.73 kB	0 B
`./frontend/.nuxt/dist/client/pages/search/index.js`	444 B	0 B
`./frontend/.nuxt/dist/client/pages/search/index.modern.js`	448 B	0 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.js`	243 B	0 B
`./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js`	246 B	0 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.js`	266 B	0 B
`./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js`	271 B	0 B
`./frontend/.nuxt/dist/client/pages/search/video.js`	240 B	0 B
`./frontend/.nuxt/dist/client/pages/search/video.modern.js`	244 B	0 B
`./frontend/.nuxt/dist/client/runtime.js`	2.72 kB	0 B
`./frontend/.nuxt/dist/client/runtime.modern.js`	2.73 kB	0 B
`./frontend/.nuxt/dist/client/vendors/app.js`	64.1 kB	0 B
`./frontend/.nuxt/dist/client/vendors/app.modern.js`	63.3 kB	0 B

_{compressed-size-action}

github-actions · 2023-03-24T14:54:09Z

Full-stack documentation: https://docs.openverse.org/_preview/1021

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

zackkrida

👍 The old one was cartoonishly large, very nice.

fcoveram

The button looks great ✨ Nice work.

I noticed you used description bold style for the label. I want to point out that the default style should be label bold, as decided here.

But in this case, the change looks better. So approving the changes ✅

obulat changed the base branch from main to add_new_buttons March 24, 2023 14:45

obulat added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend 🟨 priority: medium Not blocking but should be addressed soon labels Mar 24, 2023

obulat force-pushed the update/sources_button branch from 6eebe94 to c001866 Compare March 24, 2023 14:58

obulat force-pushed the add_new_buttons branch from 6f2ab55 to 9bf603e Compare March 28, 2023 06:56

obulat force-pushed the update/sources_button branch 2 times, most recently from d2441ea to d3c0f38 Compare March 28, 2023 09:38

obulat force-pushed the add_new_buttons branch from 321573b to fc5fa8b Compare March 28, 2023 18:10

obulat force-pushed the update/sources_button branch from 72a1208 to 15153ff Compare March 28, 2023 18:13

obulat force-pushed the add_new_buttons branch 4 times, most recently from eb15997 to 64374df Compare March 30, 2023 12:12

obulat force-pushed the update/sources_button branch from 15153ff to dedfff7 Compare April 4, 2023 09:53

obulat force-pushed the add_new_buttons branch 2 times, most recently from f2c3ce3 to e37ce56 Compare April 4, 2023 16:10

obulat force-pushed the update/sources_button branch from dedfff7 to 8096b29 Compare April 4, 2023 16:20

Base automatically changed from add_new_buttons to main April 4, 2023 17:26

obulat force-pushed the update/sources_button branch 2 times, most recently from 0b5f209 to e01f911 Compare April 5, 2023 04:39

obulat marked this pull request as ready for review April 5, 2023 06:14

obulat requested a review from a team as a code owner April 5, 2023 06:14

obulat requested review from zackkrida and dhruvkb April 5, 2023 06:14

obulat added 3 commits April 5, 2023 19:26

Use large filled-pink for sources button

a7bc996

Use VLink's externalIcon

cca9587

Update snapshots

2632267

obulat force-pushed the update/sources_button branch from e01f911 to 2632267 Compare April 5, 2023 16:27

zackkrida approved these changes Apr 10, 2023

View reviewed changes

obulat requested a review from fcoveram April 11, 2023 11:28

obulat mentioned this pull request Apr 11, 2023

Update the buttons to use the "new" variants and sizes #1020

Closed

6 tasks

fcoveram approved these changes Apr 12, 2023

View reviewed changes

obulat merged commit be6dfe2 into main Apr 12, 2023

obulat deleted the update/sources_button branch April 12, 2023 16:35

dhruvkb pushed a commit that referenced this pull request Apr 14, 2023

Speed up some tests (#1021)

3a9ffb9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update sources button #1021

Update sources button #1021

obulat commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

zackkrida left a comment

fcoveram left a comment

Update sources button #1021

Update sources button #1021

Conversation

obulat commented Mar 24, 2023 • edited Loading

Fixes

Description

Testing Instructions

Checklist

Developer Certificate of Origin

github-actions bot commented Mar 24, 2023 • edited Loading

github-actions bot commented Mar 24, 2023 • edited Loading

zackkrida left a comment

Choose a reason for hiding this comment

fcoveram left a comment

Choose a reason for hiding this comment

obulat commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading