Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python dev packages only for local development #1009

Closed
wants to merge 5 commits into from

Conversation

krysal
Copy link
Member

@krysal krysal commented Mar 23, 2023

Fixes

Fixes #1008 by @krysal

Description

WIP

I wonder if anyone is using the proxy service, since the nginx container is coming from the same API image (just using a different target) should we remove it?

proxy:
profiles:
- api
image: nginx:alpine

Testing Instructions

  1. just api/recreate
  2. just api/ipython & notice it's the plain Django shell and not ipython, you can also try importing pytest and it will fail

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added the 🧱 stack: api Related to the Django API label Mar 23, 2023
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Mar 23, 2023
@krysal krysal force-pushed the improv/docker_api_images branch from bf18ea1 to a1d57b2 Compare March 28, 2023 15:23
@github-actions github-actions bot added the 🧱 stack: ingestion server Related to the ingestion/data refresh server label Mar 28, 2023
dhruvkb pushed a commit that referenced this pull request Apr 14, 2023
* Ensure uniqueness when load table name is cut off due to long provider name

* Shorten load table prefix
@sarayourfriend
Copy link
Collaborator

@krysal Do you intend to keep working on this PR? If so, is it blocked or need assistance otherwise?

@krysal
Copy link
Member Author

krysal commented Apr 20, 2023

Since the files touched here have drifted too much, I'll start this from scratch.

@krysal krysal closed this Apr 20, 2023
@krysal krysal deleted the improv/docker_api_images branch April 20, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce size of API production image
2 participants