Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested modal handling #635

Closed
1 task
sarayourfriend opened this issue Dec 22, 2021 · 1 comment
Closed
1 task

Nested modal handling #635

sarayourfriend opened this issue Dec 22, 2021 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@sarayourfriend
Copy link
Collaborator

Problem

For WordPress/openverse-frontend#541 we'll need to be able to simulataneously have a full-screen mobile modal (matching the designs from @panchovm for Modal S presented here) and an "alert" type modal for the license information box in the filters selection.

Description

We'll need at least one new prop to indicate that the modal should be this new alert style (perhaps we can have a variant prop that is typed as 'fullscreen' | 'alert'?).

Additionally, we'll have to fix whatever issue is currently plagueing the teleport target that is causing the nested modal to close all the modals on the screen. You can test this out in storybook by adding a simple nested modal in the modal story. Everything that I'm seeing with the teleport component indicates that it should just work so I think there's something specifically wrong with the modal implementation that is causing it to fail at the moment.

Here's how it behaves at the moment:

Gravacao.de.Tela.2021-12-22.as.08.28.12.mov

It's hard to tell in the video but clicking the "nested modal" button causes the original modal to close, and then the first click on the original modal trigger does nothing. Clicking a second time will open the original modal.

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Dec 22, 2021
@zackkrida zackkrida removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Jan 3, 2022
@sarayourfriend sarayourfriend self-assigned this Jan 13, 2022
@sarayourfriend
Copy link
Collaborator Author

This may actually be unnecessary. While working on WordPress/openverse-frontend#601 it seemed to work mostly okay, with some minor bugs in focusing the disclosure element on close, but nothing major. I'm going to downgrade this to low priority and unassign myself from this for now.

@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed and removed 🟧 priority: high Stalls work on the project or its dependents labels Jan 24, 2022
@sarayourfriend sarayourfriend removed their assignment Jan 24, 2022
@obulat obulat mentioned this issue Feb 18, 2023
2 tasks
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
* Use the default provider categories during ingestion

* Enable not using the default category by passing `Unknown` (for Flickr)

* Remove default category from Flickr

* Add tests for category in MediaStore

* Simplify assigning category

* Remove outdated comments

Signed-off-by: Olga Bulat <[email protected]>

Co-authored-by: Zack Krida <[email protected]>

Co-authored-by: Madison Swain-Bowden <[email protected]>
Co-authored-by: Zack Krida <[email protected]>
@obulat obulat closed this as completed Aug 11, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

No branches or pull requests

3 participants