This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Move dev-specific services into compose overrides file #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #212 by @AetherUnbound
Description
This PR moves the
s3
andpostgres
services which are only used in development into thedocker-compose.overrides.yml
. Thanks to #153, running commands with the override file during the dev process is relatively easy. We cannot remove services with an override file (only add or override). Production only needs one service and local development needs three, our new default is that the baredocker-compose.yml
file is used for production, and the override file is used for local development.I've also updated the tests action use the appropriate docker-compose command for launching the test. This will be replaced with
just
in #216.Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin