Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the close, chevrons, and ellipsis icons #9814

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

jasmussen
Copy link
Contributor

This applies the beginnings of a grid to the icons in the right side of the editor.

This is either a complement to, or a replacement for #9784.

Before:

screen shot 2018-09-12 at 11 29 05

After:

screen shot 2018-09-12 at 11 28 58

Look closely. Closelier. The ellipsis, x and down chevron are aligned.

This applies the beginnings of a grid to the icons in the right side of the editor.
@jasmussen jasmussen added the Needs Design Feedback Needs general design feedback. label Sep 12, 2018
@jasmussen jasmussen added this to the 3.9 milestone Sep 12, 2018
@jasmussen jasmussen self-assigned this Sep 12, 2018
@jasmussen jasmussen requested review from karmatosed and a team September 12, 2018 09:29
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mtias mtias merged commit 7eb1252 into master Sep 12, 2018
@mtias mtias deleted the polish/align-close-button branch September 12, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants