Hotfix for publishing pages #9161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
approved these changes
Aug 20, 2018
|
Yeah :( I'll do that today. Need to dig into how taxonomies are retrieved and modify that test case. |
aduth
reviewed
Aug 20, 2018
| @@ -60,7 +60,7 @@ export default compose( | |||
| withSelect( ( select ) => { | |||
| const postType = select( 'core/editor' ).getCurrentPostType(); | |||
| const tagsTaxonomy = select( 'core' ).getTaxonomy( 'post_tag' ); | |||
| const tags = select( 'core/editor' ).getEditedPostAttribute( tagsTaxonomy.rest_base ); | |||
| const tags = tagsTaxonomy && select( 'core/editor' ).getEditedPostAttribute( tagsTaxonomy.rest_base ); | |||
| return { | |||
| areTagsFetched: tagsTaxonomy !== undefined, | |||
| isPostTypeSupported: tagsTaxonomy && tagsTaxonomy.types.some( ( type ) => type === postType ), | |||
There was a problem hiding this comment.
FWIW on the line below this one we're passing hasTags, which reads as though it's a boolean value, but following the && and its behavior of using the lefthand value, we're likely passing null or undefined when there are no tags, not false.
Making a point of it here only because this tends to be overlooked in applying the && pattern for conditions, added here.
|
@nosolosw Can we make sure merged pull requests are assigned to milestones, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix for #9054