Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when Cloudflare blocks REST API requests #8640

Merged
merged 14 commits into from
Aug 8, 2018
Merged

Add a warning when Cloudflare blocks REST API requests #8640

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1bd7f2a
Catch a Cloudflare response, and redirect to the Classic editor..
pento Aug 7, 2018
6148a05
Ensure the url package is loaded when api-fetch needs it.
pento Aug 7, 2018
b8af9ea
Show a message in the Classic Editor when we redirect there from a Cl…
pento Aug 7, 2018
598a73a
Don't auto-redirect to Classic, give a link, instead.
pento Aug 7, 2018
d41f658
Linting.
pento Aug 7, 2018
8c384cc
Pinking shears
pento Aug 7, 2018
4ad8095
Fix the incorrect Cloudflare rule ID being listed.
pento Aug 7, 2018
671208e
Mock Resonse.clone() in the tests.
pento Aug 7, 2018
9191016
Make checkCloudflareError() more resilient to non-strings being passe…
pento Aug 7, 2018
2219590
Use typeof instead of checking for .indexOf on the error to check tha…
pento Aug 8, 2018
fbe7d6f
s/login/log in/
pento Aug 8, 2018
483beab
Improve translator comments.
pento Aug 8, 2018
9c70019
Improve readability of the JSON parsing error handling
pento Aug 8, 2018
468d024
Add a comment explaining why the response is being cloned.
pento Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Linting.
  • Loading branch information
@pento
pento committed Aug 7, 2018
commit d41f6582093d8ba8cc3b60f946bf41295d0be44b
4 changes: 2 additions & 2 deletions lib/compat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,8 @@ function gutenberg_warn_classic_about_cloudflare() {
<li><?php _e( 'If you have a Cloudflare Pro account, login to Cloudflare, visit the Firewall settings page, open the "Cloudflare Rule Set" details, open the "Cloudflare WordPress" ruleset, then set the rules "WP0025A" and "WP0025A" to "Disable".', 'gutenberg' ); ?></li>
Copy link
Member

@gziolo gziolo Aug 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"WP0025A" and "WP0025A" - the same id is listed twice.

If I follow the description of the PR right, it should be "WP0025A" and "WP0025B"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

<li>
<?php
/* translators: link to a comment in the Gutenberg repo */
printf(
/* translators: link to a comment in the Gutenberg repo */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be /* translators: %s: link to a comment in the Gutenberg GitHub repository */

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

__( 'For free Cloudflare accounts, you can <a href="%s">change the REST API URL</a>, to avoid triggering the WAF rules. Please be aware that this may cause issues with other plugins that use the REST API, and removes any other protection Cloudflare may be offering for the REST API.', 'gutenberg' ),
'https://github.com/WordPress/gutenberg/issues/2704#issuecomment-410582252'
);
Expand All @@ -378,8 +378,8 @@ function gutenberg_warn_classic_about_cloudflare() {
</ul>
<p>
<?php
/* translators: link to an issue in the Gutenberg repo */
printf(
/* translators: link to an issue in the Gutenberg repo */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again missing the %s in the comment + I wouldn't shorten repository here.

/* translators: %s: link to an issue in the Gutenberg GitHub repository */

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

__( 'If neither of these options are possible for you, please <a href="%s">follow this issue for updates</a>. We hope to have this issue rectifed soon!', 'gutenberg' ),
'https://github.com/WordPress/gutenberg/issues/2704'
);
Expand Down