Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't register rewrite rules for the wp_blocks post type #8260

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Don't register rewrite rules for the wp_blocks post type #8260

merged 1 commit into from
Jul 30, 2018

Conversation

chrisvanpatten
Copy link
Contributor

@chrisvanpatten chrisvanpatten commented Jul 27, 2018 •
edited
Loading

Description

Sets rewrite to false so rewrite rules aren't generated for shared/reusable blocks (the wp_block post type).

Fixes #8233.

How has this been tested?

Tested with the wp rewrite list CLI command and then creating a shared/reusable block and inserting it into another page.

Types of changes

Bug fix; removes unused rewrite rules for shared/reusable blocks

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@pento pento added the [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) label Jul 30, 2018
@pento pento added this to the 3.4 milestone Jul 30, 2018
@pento pento merged commit 72384a6 into WordPress:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks)
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

wp_block post type adds unnecessary rewrite rules
3 participants
@chrisvanpatten @swissspidy @pento