Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Server Fixtures generator #8126

Closed
wants to merge 2 commits into from
Closed

Fix the Server Fixtures generator #8126

wants to merge 2 commits into from

Conversation

pento
Copy link
Member

@pento pento commented Jul 23, 2018

Description

After #7941, the server fixture generator stopped working. (core-blocks/latest-comments/index.php includes wp-admin/includes/template.php, which includes wp-admin/includes/class-walker-category-checklist.php, which expects wp-includes/class-wp-walker.php to have already been included.)

This PR fixes the generator, and re-generates the fixtures with the Latest Comments block data included.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@pento pento added [Type] Build Tooling Issues or PRs related to build tooling [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Jul 23, 2018
@pento pento added this to the 3.4 milestone Jul 23, 2018
@pento pento self-assigned this Jul 23, 2018
@pento pento requested a review from a team July 23, 2018 07:18
@Soean
Copy link
Member

Soean commented Jul 23, 2018

Related to #8085

@pento
Copy link
Member Author

pento commented Jul 23, 2018

Whee, I missed that PR. Closing in favour of #8085.

@pento pento closed this Jul 23, 2018
@pento pento removed this from the 3.4 milestone Jul 23, 2018
@pento pento deleted the fix/server-fixtures branch July 23, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants