chore: Improve eslint checks for deep imports #8013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
force-pushed
the
chore/improve-eslint-rules-for-deep-imports
branch
from
393aeb1 to
808495e
Compare
aduth
added
the
[Type] Automated Testing
|
I'm actually wondering if we need a good chunk of these or not, specifically those in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #7941 (comment)
I tested this locally with the existing codebase; it threw no errors but adding either:
import { DEFAULT_CONTROLS } from 'editor/components/block-alignment-toolbar';import { DEFAULT_CONTROLS } from 'editor';would cause errors, which is the intended effect.