Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include title in the anchor tag for better user accessibility. #69499

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

HILAYTRIVEDI
Copy link
Contributor

What?

Closes #69496

Why?

This PR will reuse the title attribute in the image in the anchor link also so that when the user will hover over the image the tooltip will be appear.

How?

Screenshot 2025-03-09 at 7 04 01 PM

This PR will use the default attribute of the anchor link to populate the title of the image.

Testing Instructions

  1. Add the image block
  2. Add the link and title attribute of the image
  3. On the front end when you hover over the image you will see the tool tip.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2025-03-09 at 6 54 09 PM Screenshot 2025-03-09 at 6 53 52 PM

Copy link

github-actions bot commented Mar 9, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Mar 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @srikanthvlr.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: srikanthvlr.

Co-authored-by: HILAYTRIVEDI <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@HILAYTRIVEDI HILAYTRIVEDI marked this pull request as draft March 9, 2025 13:37
@HILAYTRIVEDI HILAYTRIVEDI marked this pull request as ready for review March 9, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"title" attribute for figure/image block
1 participant