Site Editor: Fix template lookup preloading for non-draft pages #69400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
fix/site-editor-page-template-lookup
branch
from
da72e80 to
508935c
Compare
Mamaduka
commented
Mar 4, 2025
| @@ -68,8 +68,8 @@ function gutenberg_block_editor_preload_paths_6_8( $paths, $context ) { | |||
| * See the call to `canUser()`, under `useGlobalStylesUserConfig()` in `packages/edit-site/src/components/use-global-styles-user-config/index.js`. | |||
| * Please ensure that the equivalent check is kept in sync with this preload path. | |||
| */ | |||
| $context = current_user_can( 'edit_theme_options' ) ? 'edit' : 'view'; | |||
| $paths[] = "/wp/v2/global-styles/$global_styles_id?context=$context"; | |||
| $rest_context = current_user_can( 'edit_theme_options' ) ? 'edit' : 'view'; | |||
There was a problem hiding this comment.
Avoids overriding the $context argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Discovered while re-testing: WordPress/wordpress-develop#8441.
Fixes the
slugfor preloading page templates and adds a handler for draft pages.Why?
The pages with draft status might not have a
slugavailable; the client code handles this, but it was missing from the preloading logic.Testing Instructions
lookupendpoint should be correctly preloaded.Testing Instructions for Keyboard
Same.
Screenshots or screencast