Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Add Ko-fi.com to the Social Icon block #68904

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

Mayank-Tripathi32
Copy link
Contributor

resolves #68901

What?

Adds Ko-fi as a new social link option to the Social Links block

Why?

Ko-fi is a popular platform for creators to receive support from their community. Adding Ko-fi support to the Social Links block will help WordPress users better connect with their audience and provide an easy way for visitors to support their work. This enhancement aligns with having patreon icon as ko-fi is its competitor.

How?

  • Added new Ko-fi icon component using SVG primitives
  • Implemented proper ID management using withInstanceId to prevent conflicts
  • Added Ko-fi to the supported social media platforms in the Social Links block
  • Maintained consistent styling with other social icons in the block, used svg from ko-fi official asset files.

Testing Instructions

  • Add a Social Links block to a post or page
  • Click the "+" button to add a new social link
  • Search for "Ko-fi" in the social link options
  • Add your Ko-fi profile URL
  • Verify the Ko-fi icon appears correctly with ko-fi latest icon pack from their assets.
  • Check that hovering shows the correct hover state
  • Verify the link works correctly in both editor and frontend views
  • Test that the icon displays properly at different block sizes
  • Ensure the icon maintains quality across different screen sizes and devices

Screenshots

image

image

Copy link

github-actions bot commented Jan 27, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @oskar-ok-strom.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: oskar-ok-strom.

Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: asafm7 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Jan 28, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Feb 5, 2025

Related #39609 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ko-fi.com to the Social Icon block and/or add an option to a custom service button
3 participants