Block Editor: Fix 'isBlockVisibleInTheInserter' selector helper performance #68898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ktmn. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
|
Size Change: +11 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jan 27, 2025
|
It would be cool to be able to catch this kind of regression in the perf metrics at some point (maybe we should add a nested navigation block or something) |
100%. Maybe a separate metric to avoid accidentally affecting other metrics. |
|
@youknowriad, @mmtr, is this good to merge? |
|
This fixes the issue for me when I test locally with both CoBlocks and WooCommerce active: Screen.Recording.2025-01-28.at.13.09.36.mov |
mmtr
approved these changes
Jan 28, 2025
|
Thanks for the confirmation and for providing the patch in the hotfix ticket! |
zaguiini
pushed a commit
that referenced
this pull request
Feb 19, 2025
…rmance (#68898) * Block Editor: Fix 'isBlockVisibleInTheInserter' selector helper performance * Use the loop, Luke! Unlinked contributors: ktmn. Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: mmtr <[email protected]>
cbravobernal
pushed a commit
that referenced
this pull request
Feb 19, 2025
…rmance (#68898) (#69251) * Block Editor: Fix 'isBlockVisibleInTheInserter' selector helper performance * Use the loop, Luke! Unlinked contributors: ktmn. Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: mmtr <[email protected]>
zaguiini
added
the
Backport to Gutenberg Minor Release
zaguiini
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #68875.
Fixes recent performance regression in the Block Editor package.
Why?
The
isBlockVisibleInTheInserterfunction is often called even when the inserter isn't visible. The internal functiongetBlockParentsByBlockNameis a memoized selector but receives a newparentsarray reference on every call.Calling a memoized selector with an unstable argument reference can degrade performance.
Testing Instructions
Notes:
Testing Instructions for Keyboard
Same.
Screenshots or screencast