Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Pagination: Add example attribute to block #68337

Merged

Conversation

Infinite-Null
Copy link
Contributor

Part of #64707

What?

This PR adds an example attribute to the Comments Pagination block’s block.json to provide a default paginationArrow.

Testing Instructions

  1. Open a post or page in the WordPress block editor.
  2. Open the block inserter by clicking the “+” button.
  3. Add comments block and search for comments pagination block.
  4. Hover over the comments pagination block in the inserter.

Screenshots

Before After
image image

Copy link

github-actions bot commented Dec 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Style Book [Type] Enhancement A suggestion for improvement. [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop and removed Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Style Book labels Dec 29, 2024
@carolinan
Copy link
Contributor

I found it confusing that the comments pagination and comment pagination numbers share the same preview, but I think it is better than leaving the empty grey box.

@carolinan
Copy link
Contributor

carolinan commented Jan 23, 2025

Screenshot of Appearance > Editor > Styles > Blocks > Comments pagination > Stylebook

image

@carolinan carolinan merged commit f14a977 into WordPress:trunk Jan 24, 2025
72 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants