Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate 'Copy' and 'Copy styles' snackbar confirmation messages #68167

Merged
merged 15 commits into from
Jan 8, 2025

Conversation

karthick-murugan
Copy link
Contributor

What?

Fixes #57254

Differentiates snackbar confirmation messages for "Copy" and "Copy styles" operations.

Why?

Currently, the snackbar messages for both "Copy" and "Copy styles" operations display the same text, causing confusion for users. This update introduces distinct messages to improve clarity and the user experience.

How?

  • Updated snackbar messages for "Copy" and "Copy styles" actions.
  • Implemented conditional logic to display appropriate messages depending on the action performed.

Testing Instructions

  1. Open the post editor and add a block.
  2. Use the "Copy" option from the block toolbar and verify the snackbar displays: Copied "%s" to clipboard.
  3. Use the "Copy styles" option from the block toolbar and verify the snackbar displays: Styles copied to clipboard.
  4. Ensure both actions work correctly using keyboard navigation.

Video

REC-20241220125454.mp4

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@karthick-murugan
Copy link
Contributor Author

@afercia - Please have a look at this PR when you get some time.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Package] Block editor /packages/block-editor labels Jan 8, 2025
Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@afercia afercia merged commit 54f59fe into WordPress:trunk Jan 8, 2025
68 of 69 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 8, 2025
Gulamdastgir-Momin pushed a commit to Gulamdastgir-Momin/gutenberg that referenced this pull request Jan 23, 2025
…WordPress#68167)

* Image size fix in lightbox

* Revert "Image size fix in lightbox"

This reverts commit 63f81c1.

* Update Snackbar messages for copy event

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: afercia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiate 'Copy' and 'Copy styles' snackbar confirmation messages
2 participants