Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: Set .wp-block-media-text__media a display to block #66915

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Nov 11, 2024

Fixes: #66914

What?

Ajusted the display property from inline-block to block to resolve layout issues in the Media & Text block anchor link.

Why?

This PR is necessary address a display issue when an anchor link is added to the Media & Text block. The current inline-block display style results in reduced and inconsistent media sizes.

Testing Instructions

  1. Go to any post
  2. Add Media & Text Block
  3. Select an image
  4. Add an anchor link to block and save
  5. Check frontend

Screenshots or screencast

Issue

FRONTEND

After Fix

FRONTEND (1)

Ajusted the display property from `inline-block` to `block` to resolve layout issues in the Media & Text block anchor link.
Copy link

github-actions bot commented Nov 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ajmaurya99 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Infinite-Null! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 11, 2024
@carolinan carolinan added [Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended labels Nov 12, 2024
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this manually in Chrome and Firefox on PC. Using display: block instead of display: inline-block seems to work:

  • The image in the media part of the block has the same size no matter if it is linked or not
  • The image in the media part of the block has the same size in the editor and front
  • The focus outline is correct, it wraps the whole image

@Mamaduka
Copy link
Member

The inline-block rule was initially introduced in #62556 to solve the focus outline issue.

@Mamaduka Mamaduka changed the title Set .wp-block-media-text__media a display to block Media & Text: Set .wp-block-media-text__media a display to block Nov 12, 2024
@Mamaduka Mamaduka merged commit 99fd9c7 into WordPress:trunk Nov 12, 2024
68 of 70 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.7 milestone Nov 12, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
…ordPress#66915)

Ajusted the display property from `inline-block` to `block` to resolve layout issues in the Media & Text block anchor link.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ajmaurya99 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Anchor Link to Media & Text Block Sets Link to Inline-Block
3 participants