-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media & Text: Set .wp-block-media-text__media a
display to block
#66915
Media & Text: Set .wp-block-media-text__media a
display to block
#66915
Conversation
Ajusted the display property from `inline-block` to `block` to resolve layout issues in the Media & Text block anchor link.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Infinite-Null! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this manually in Chrome and Firefox on PC. Using display: block
instead of display: inline-block
seems to work:
- The image in the media part of the block has the same size no matter if it is linked or not
- The image in the media part of the block has the same size in the editor and front
- The focus outline is correct, it wraps the whole image
The |
.wp-block-media-text__media a
display to block.wp-block-media-text__media a
display to block
…ordPress#66915) Ajusted the display property from `inline-block` to `block` to resolve layout issues in the Media & Text block anchor link. Co-authored-by: Infinite-Null <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ajmaurya99 <[email protected]>
Fixes: #66914
What?
Ajusted the display property from
inline-block
toblock
to resolve layout issues in the Media & Text block anchor link.Why?
This PR is necessary address a display issue when an anchor link is added to the Media & Text block. The current inline-block display style results in reduced and inconsistent media sizes.
Testing Instructions
Screenshots or screencast
Issue
After Fix