Site Editor: fix template for page-on-front option #66739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Nov 5, 2024
| } else { | ||
| // Still resolving `templates`. | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
See https://github.com/WordPress/gutenberg/pull/66579/files#diff-90ac1a8edea4ffca3eb4acd2bc2aeed05d54392fc843eb1f253403ae66771dceL59-L66, which has the same logic, but spread over three different pieces: two in the first selector, and one in the second. I put them all together here.
6 tasks
|
Size Change: +26 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Nov 5, 2024
|
Thanks for fixing this so quickly! |
|
Thanks for not reverting my PR 😄 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: mdawaffe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I removed a bit too much logic in #66579. I thought the
/lookupREST API request could handle fetching the front-page template when the page-on-front option is set, but it can't. Ideally we should fix the endpoint, but in the meantime, I'll restore the previous logic (and add more inline comments).Why?
Fixes #66687.
How?
Restores logic from #66579, closer to where it's needed and with more comments.
When a front page ID is set, the correct front-page hierarchy is first the
front-pagetemplate, then the specific page template for the front page ID. This was previously manually checked in JS. It looked specifically for the front page template and if it doesn't exist, continue with the remaining logic to find the page template.Testing Instructions
Set a page to be the front page in Reading settings. The front-end's front page should have changed. Check that it's the same in the site editor.
Testing Instructions for Keyboard
Screenshots or screencast