Fix: Show paragraph block variations in rich text inserter #66318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
commented
Oct 22, 2024
| ? getBlockName( selectedBlockClientId ) | ||
| : null, | ||
| selectedBlockId: activeBlockVariation | ||
| ? `${ blockName }/${ activeBlockVariation.name }` |
There was a problem hiding this comment.
I am not sure if there is a better way to get the block id of the block variation.
There was a problem hiding this comment.
I think it's the way to go. See existing code as the reference:
gutenberg/packages/block-editor/src/store/selectors.js
Lines 1982 to 1983 in d0771cd
|
Size Change: +31 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
There is a JavaScript linting error reported that was likely addressed with d0771cd. |
gziolo
added
[Feature] Inserter
SantosGuillamot
force-pushed
the
fix/show-block-variations-in-rich-text-inserter
branch
from
5d82cb0 to
814c60a
Compare
|
I've rebased to see if the problem is solved |
|
Before 
After 
|
gziolo
approved these changes
Oct 23, 2024
SantosGuillamot
deleted the
fix/show-block-variations-in-rich-text-inserter
branch
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: gziolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by @DAreRodz
What?
Right now, when a user creates a block variation of the paragraph block, it doesn't appear in the inserter of the rich text. In this pull request, I propose including them, but I'd like to ask if this is intended or not.
If we want to change the current behavior, I can add some e2e tests.
How it works right now
When you type
/in a paragraph block, it shows neither the paragraph or the block variations in the inserter.How it works in this pull request
Why?
It could make sense to include variations there to replicate the behavior of the inserter, as discussed here: #23364
How?
I'm checking the
item.idinstead of theitem.name. It is the only way I found to differ between variations and the default block.Testing Instructions
/and check the paragraph doesn't show./redand check the variation shows./and check the paragraph shows./redand check the variation doesn't show.