Tools: Enforce the same order of fields in package.json files
#66239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ellatrix,
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
peterwilsoncc,
ntwb,
nerrad,
luisherranz,
DAreRodz,
draganescu,
adamziel,
kevin940726,
dmsnell,
atimmer and
mmtr
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.82 MB ℹ️ View Unchanged
|
sirreal
force-pushed
the
managing-packages
branch
from
d10c7d6 to
770ab08
Compare
sirreal
requested review from
ObliviousHarmony,
t-hamano,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
gziolo
force-pushed
the
update/package-json-linting
branch
from
442fea4 to
e5eab2e
Compare
this should be done another way
Co-authored-by: Jon Surrell <[email protected]>
gziolo
force-pushed
the
update/package-json-linting
branch
from
e5eab2e to
1fa15cc
Compare
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…Press#66239) * Update package managing flow * Adapt packages webpack config for workspaces * Ignore "dev" scripts this should be done another way * Annotate packages included as WordPress scripts * Do not annotate react-native packages * Update packages webpack to use wpScript package.json * Implement Gutenberg specific check-licenses script * Remove redundant entries from the ignore list * Update some docs langauge about lerna and npm workspaces * Tools: Enforce the same order of fields in `package.json` files * Update the PR number in the changelog entry * Update packages/npm-package-json-lint-config/index.js Co-authored-by: Jon Surrell <[email protected]> * Update CHANGELOG.md * Update the order of properties added recently --------- Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Depends on:
There were new properties introduced in
package.jsonfiles that are located in random order inpackage.jsonfiles:exportswpScriptwpScriptModuleExportssideEffectsWhy?
It's easier to have consitent order of fields when maintaining nearly 100 npm packages.
How?
Extend the config for
prefer-property-orderrule in@wordpress/npm-package-json-lint-config.