-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/site icon focus #65936
Closed
karthick-murugan
wants to merge
489
commits into
WordPress:trunk
from
karthick-murugan:fix/site-icon-focus
Closed
Fix/site icon focus #65936
Changes from 4 commits
Commits
Show all changes
489 commits
Select commit
Hold shift + click to select a range
f2207fb
Remove toggle verb from post list data views (#66334)
AhmarZaidi 2f1cd93
Zoom Out: Use the zoom-level value to scale the iframe (#66280)
youknowriad 90395cf
Quick Edit: Fix JS error when bulk editing pages (#66358)
youknowriad e9b7e5a
Zoom Out: Remove double click to exit hook from the block-editor pack…
youknowriad 5d6c657
Use npm workspaces for packages (second attempt) (#66272)
sirreal 3e81dfb
Interface: Use plugin context hook instead of HoC (#66362)
Mamaduka 45d17d6
Bump plugin version to 19.5.0
gutenbergplugin ed96e6c
Update Changelog for 19.5.0
gutenbergplugin 01ab778
Block editor: remove patterns UI stylesheet from iframe (#66306)
ellatrix f561b6c
Plugins: Deprecate 'withPluginContext' HOC (#66363)
Mamaduka df94e68
QuickEdit: Add Featured Image Control (#64496)
gigitux 0f6f866
Footnotes: Remove extra callback when parsing content (#66370)
tyxla 39e004c
QuickEdit: Add slug field control (#65196)
gigitux 1ed4a31
Add Inline comment experimental flag (#60622)
poojabhimani12 b339fbf
Make useZoomOut hook private (#66374)
jeryj 58bd7be
Style Book: Add color tab (#65692)
aaronrobertshaw 49ffaf4
Backport: Caching of global styles for blocks from core (#66349)
aaronrobertshaw 77b2ea4
Fix typo after #63669. (#66396)
afercia 39b665d
Block registration: normalize blockType.parent to `array` (#66250)
oandregal 4934df0
Add radius foundation and tokens to storybook (#66219)
jameskoster e0e2353
Add Transformation from Separator to Spacer (#66230)
rudrakshi-gupta 883fc3d
Search: Replace ButtonGroup usage with ToggleGroupControl (#65340)
Mamaduka f92c74f
ESLint: Fix a couple of React Compiler reassignment errors (#66331)
tyxla ed52d86
Block Editor: Fix 'useInstanceId' hook reference (#66406)
Mamaduka 4a1711c
Change text color to gray-800 to improve color contrast (#66360)
Vrishabhsk 7031d6e
Gallery: Fix React Comiler reassignment error (#66408)
Mamaduka a27bb89
Border support added to comments (#66354)
rinkalpagdar 424b7d9
Block Library: Cleanup unnecessary notice removal (#66409)
tyxla 2f82ee5
Global Styles: Fix React Compiler variable mutation error (#66410)
Mamaduka ed92196
Zoom Out: Fix bouncy drop zones (#66399)
talldan a072cdc
Remove meetings (#66421)
ndiego 90497af
Site editor: remove "default" admin CSS (#66431)
ellatrix 6bf329d
Fix: JSON Schema Docgen doesn't work on Windows OS (#66414)
t-hamano 94c7470
Revise zoom layout shift fix (#66390)
stokesman e0c8af9
Zoom out: Add keyboard shortcut in editor (#66400)
ntsekouras 6f7dc00
Compose: Fix React Complier error for 'useCopyToClipboard' (#66444)
Mamaduka 70a8d2b
Style Book: Fix React Compiler error (#66445)
Mamaduka c73ad8c
Documenation: Update documentation about build process changes (#66428)
sirreal a21bdbc
Button Block: Apply Stretch Styles Correctly (#64770)
t-hamano 89fe687
Style Book: Avoid state/effect combo when generating values (#66446)
Mamaduka caa1d96
Tabs and ToggleGroupControl: round indicator size (#66426)
ciampo b2e9eba
HTML Block: Force HTML preview in view mode (#66440)
t-hamano 9a876cd
ESLint: Stop disabling `react-hooks/exhaustive-deps` rule (#66324)
tyxla 80919d0
Don't switch editor mode when changing entities (#66452)
getdave 66abeed
Remove purple coloring from DocumentBar and PostCard (#66451)
ntsekouras 38660ca
ESLint: Remove explicit react-hooks/exhaustive-deps disabling (#66461)
tyxla 3f882fa
Fields: Fix React Compiler mutation errors (#66464)
tyxla d61856c
Remove viewport check from useZoomOut hook (#66341)
jeryj 06f9dd6
Rich Text: Fix React Complier error for 'useEventListeners' (#66460)
Mamaduka 26167f5
Iterate zoom out shuffle into a more visual control (#66194)
ntsekouras 44940bc
Site Editor: remove content styles outside canvas (#66432)
ellatrix 58d26a0
Follow up of 66451 - leftovers from removed styles (#66472)
ntsekouras bc8e73f
Style Book: fix comment output in styles (#66439)
stokesman b0f019c
Set `ResizableEditor` height based on border-box (#66342)
stokesman f771780
Editor: Multi-entity saving: Show correct count of entities to be sav…
mcsf 3d11082
BorderBoxControl: Deprecate 36px default size (#65752)
mirka eed293d
BorderControl: Deprecate 36px default size (#65755)
mirka b0999ee
DrodownMenuV2: Rename folder to `menu` (#66473)
ciampo e9d473c
Meta boxes: Fix typo "metabox pane" to "meta box panel". (#66502)
peterwilsoncc 371497e
Misc i18n fixes (#66510)
swissspidy 2883f6e
Improve the link preview accessibility and labels. (#60908)
afercia c21a8ea
Create Block: Adds `--target-dir` flag to allow the tool to target wh…
ryanwelcher ce39e34
Fix: Text overflow in Patterns filter (#66504)
t-hamano 4c1b196
Site Editor: Fix button hover style in sidebar navigation screen (#66…
t-hamano 1c4c606
Show paragraph block variations in rich text inserter (#66318)
SantosGuillamot 3975cff
BaseControl: Auto-generate readme (#66500)
mirka d3606ad
Preload: fix multiple regressions around global styles (#66468)
ellatrix b96bc6f
Tabs: remove custom logic (#66097)
ciampo 3da4c52
Navigation: Improve trigger for fallback navigation (#66478)
tyxla d3b3053
README: Add Storybook badge (#66529)
tyxla fa3a328
Revert 66431 (Site editor: remove "default" admin CSS) (#66540)
andrewserong ebc21fb
Fix extraneous scrollbar in device previews (#66494)
stokesman b6b227c
Global styles: move preload paths filter to 6.7 (previously 6.8) (#66…
ramonjd 5c41636
Composer: Fix React Compiler errors for 'useDropZone' (#66469)
Mamaduka 8482b55
Block Editor: Fix React Complier error for Duotone (#66492)
Mamaduka 1060ce2
Block Editor: Fix React Complier error for 'useEventListeners' (#66495)
Mamaduka a743dc1
Components: Fix React Compiler error for 'useAutocomplete' (#66496)
Mamaduka a33fabc
Site editor: Fix save shortcut (#66423)
ntsekouras 7b37f55
Create block: Ensure $slug is replaced with passed slug (#66528)
ryanwelcher 638f60b
WP Scripts: Add a `--root-folder` argument to the `plugin-zip` comman…
nicolasgalvez 9501c2a
ImageSizeControls: Replace ButtonGroup with ToggleGroupControl (#65386)
hbhalodia 105cafb
Fix undo/redo Button size in Storybook playground (#66538)
mirka 88ffd05
Import only the actually used PostCSS exports (#66379)
jsnajdr a952ff0
Fix: Improve the DocumentBar post type label for the Homepage and Pos…
hbhalodia 871f5cb
Remove most of the occurrences of the verb toggle. (#66371)
afercia 31ee948
Rich text: remove empty file (#66553)
swissspidy 391538b
TabPanel: Add 40px size prop to tab Button (#66557)
mirka ff4f58d
`DropdownMenuV2`: rename to `Menu` (#66289)
ciampo 77377da
PostTaxonomiesFlatTermSelector: Restore space between tag list and mo…
t-hamano 1b71028
Fix zoom out shortcut on Windows (#66506)
t-hamano 78a5bc5
Interface: remove unused private API support (#66565)
jsnajdr bd1c64c
Backport from Core: Reuse block metadata in WP_Theme_JSON::get_valid_…
ramonjd 14d3cbd
Fix Parent Check Condition in `buildTermsTree` (#66006)
torounit 9a158d4
Templates: hide mediaField in list view if not provided (#66573)
oandregal fbb65cc
QuickEdit: Add Parent field (#66527)
gigitux db7e33f
Backport from WordPres core: Improvements for the post format query l…
carolinan ca0188f
Inline Commenting: Disable comments on published posts for now (#66583)
rinkalpagdar 7b2f37d
Core Data: Add the 'getEntitiesConfig' resolver (#65871)
Mamaduka 4d4b5a2
Bump plugin version to 19.6.0-rc.1
gutenbergplugin e6c01eb
Inline Commenting: Optimize store selector and misc changes (#66592)
Mamaduka 6ffa436
Update changelog files
gutenbergplugin 27af9ac
chore(release): publish
gutenbergplugin f068fb3
Update Changelog for 19.6.0-rc.1
gutenbergplugin a8abe7b
Introduce React Scanner for component usage stats (#65463)
tyxla e9521b5
Storybook: Log `warning()` when in dev mode (#66568)
mirka 1f6d37a
Panel: Add 40px size prop to Button (#66589)
mirka 6d3c43d
Bump the github-actions group across 1 directory with 2 updates (#66475)
dependabot[bot] 310d87a
Popover: Add small size prop to close button (#66587)
mirka 87e6fd2
DataViews: Fix 'aria-label' for pattern preview element (#66601)
Mamaduka ea54dc4
Snackbar: Use `link` variant for action Button (#66560)
mirka e9c417d
Add `isVisible` option to fields within DataForm (#65826)
louwie17 8e5c88f
PaletteEdit: Add appropriate size props to Buttons (#66590)
mirka 70f323b
Site Editor: restore block-library editor.css outside canvas (#66556)
ellatrix ce93c8e
Block Bindings: Docs API reference. (#66251)
cbravobernal 2bbae22
Site Editor: preload settings requests (#66488)
ellatrix d8583ab
Guide: Use small size button for page controls (#66607)
mirka bf042f1
Bump plugin version to 19.6.0-rc.2
gutenbergplugin 1934a58
Update Changelog for 19.6.0-rc.2
gutenbergplugin 7be01e6
Quick Edit - Slug Field: improve slug preview (#66559)
gigitux 1de2bb8
Notice: Add appropriate size props to Buttons (#66593)
mirka eaf0216
Improve cover block z-index solution (#66249)
renatho 5e4e303
Perf: avoid fetching all reusable blocks on load in patterns preferen…
ellatrix b48dd4e
Global styles: preload user global styles based on user caps (#66541)
ramonjd 15b1802
PostTaxonomiesFlatTermSelector: abstract wrapper component (#66625)
ramonjd f905e98
MenuItem: Add 40px size prop on Button (#66596)
mirka 8f4b9a4
Disable device preview in pattern/template part/navitation editor (#6…
t-hamano 52b3be0
Block editor: exclude wp- styles from iframe compat styles (#66628)
ellatrix 1e58365
Fix : Snackbar Notice Inconsistency (#66405)
Vrishabhsk 66c541e
Query Loop: Use templateSlug and postType for more context (#65820)
mikachan 3d88e31
QuickEdit: Add password field to the pages quick edit (#66567)
louwie17 7ffd5a3
Radio: Deprecate 36px default size (#66572)
mirka 0fd9bcb
Appender: fix outside-canvas styles (#66630)
ellatrix 277afe0
Site Editor: speed up load by preloading home and front-page template…
ellatrix f5a7be1
Fix: Show Meta Boxes at the bottom of the screen regardless of the cu…
fabiankaegy 04f0426
Site editor: preload post if needed (#66631)
ellatrix 6336dd9
Safari: fix site editor template error (#66647)
ellatrix 3a76ce4
Query Loop: Check for postTypeFromContext before using it (#66655)
mikachan 8f3dcc7
VisualEditor: Always output has-global-padding classname when in post…
andrewserong f175474
Prevent duplicate post format taxonomy queries (#66627)
carolinan 64d5c55
Theme JSON: replace top-level background style objects on merge (#66656)
ramonjd 6214d57
Media Library: Expose filters dropdown for individual images, such as…
andrewserong 882b173
Style engine: wrap array_merge in conditionals to prevent unnecessary…
ramonjd eeafd99
Editor: Restore the 'PluginPostStatusInfo' slot position (#66665)
Mamaduka 98e1217
getDefaultTemplateId: ensure entity config is loaded (#66650)
ellatrix 404825e
Convert the emitter module in data package to TS (#66669)
manzoorwanijk 8959d79
TypeScript: Fix and improve types for private-apis (#66667)
manzoorwanijk c58e9f9
Post Editor: Set the default value of the editorTool to edit (#66636)
arthur791004 6a844c4
Image block: Add support for "more" dropdown for additional tools in …
ntsekouras 792dace
Update Changelog for 19.5.1
gutenbergplugin 19a313b
Bump plugin version to 19.6.0-rc.3
gutenbergplugin 07865da
Speak 'Block moved up/down' after using keyboard actions to move up/d…
n2erjo00 235f400
Update Changelog for 19.6.0-rc.3
gutenbergplugin a047941
Optimize `getVisibleElementBounds` in scrollable cases (#66546)
stokesman 34b045f
Fix unset array key warning in block-bindings.php (#66337)
benharri 6b1a8be
FormTokenField: Fix token styles (#66640)
mirka cf48486
Typography: Stabilize typography block supports within block processi…
andrewserong 3bd2b13
Theme JSON Resolver: remove theme json merge in resolve_theme_file_ur…
ramonjd d2db683
Block Inspector: Restore bottm margin for RadioControl (#66688)
t-hamano 0770be1
Site editor: integrate global styles controls and style book preview …
jorgefilipecosta 997accf
Ensure HEIC files selectable from “Upload” button (#66292)
adamsilverstein 6e907e6
Media Utils: add experimental `sideloadMedia` (#66378)
swissspidy 6ccb4de
Query Loop: Remove postTypeFromContext (#66681)
mikachan b3579a3
Set the `fit-content` width for images that are not `.svg` (#66643)
juanfra 49ae716
Post template block: Adjust the editor preview on taxonomy archive te…
carolinan bf805cd
Inline Commenting: Avoid querying comments on editor load (#66670)
Mamaduka a695416
Components: Fix React Compiler error for 'useScrollRectIntoView' (#66…
Mamaduka 45d61bb
URLInput: Fix incorrect classname for suggestions (#66714)
t-hamano 5d1be2a
Appender: fix initial position (#66711)
t-hamano 5ffa4c1
Block toolbar: restrict visible child calculation to known blocks (#6…
ramonjd 2a63ae7
Shadow panel: Make the delete modal text translatable (#66712)
t-hamano 9c17012
ComplementaryArea: Fix button position (#66677)
t-hamano 0da67d0
Add "show template" to preview dropdown. (#66514)
tellthemachines 1809396
Remove unnecessary tooltip from Video block Text tracks button. (#66716)
afercia d3d62e7
Docs: Include a note about supported licenses in WordPress packages (…
gziolo 6ea803a
Storybook: fix Dataviews action modals (#66727)
oandregal d4a5d2b
Documentation: reorganize to bootstrap DataForm API section (#66729)
oandregal fe60afd
Document `filterSortAndPaginate` & `isItemValid` utilities (#66738)
oandregal 956ad83
Documentation: move docs for filters to proper place (#66743)
oandregal e3856d8
Documentation: add missing properties for DataViews/DataForm componen…
oandregal e62c81c
Tools: Enforce the same order of fields in `package.json` files (#66239)
gziolo bb499b8
Site Editor: fix template for page-on-front option (#66739)
ellatrix 48c9443
WP Scripts: Make watch mode more resilient for developer errors (#66752)
gziolo a372a07
Documentation: add section about the Fields API (#66761)
oandregal e7336f8
Documentation: improve readability of DataViews docs (#66766)
oandregal 9e0335f
Zoom-out: Move default background to the iframe component (#66284)
youknowriad e605968
BlockPatternsList: use the Async component (#66744)
ellatrix d062be3
Block Editor: Fix ESLint warning for 'useBlockTypesState' hook (#66757)
Mamaduka 545ed02
Perf metrics: update select and other metrics to use non-empty paragr…
ellatrix 683824d
Patterns: receive intermediate responses while unbound request is res…
ellatrix fe1de3e
Edit Site: Remove leftover 'priority-queue' dependency (#66773)
Mamaduka 9e352bd
ci: Address stalling Android E2E test tasks (#66771)
dcalhoun 424f359
Cover: Fix media library image selection (#66782)
Mamaduka e213e48
Fix TS types for editor package (#66754)
manzoorwanijk 256ac4e
Fix Paragraph appender layout shift (building on 66061) (#66779)
andrewserong 43909c6
DataViews: Tweak primary field in patterns grid layout (#66733)
t-hamano f49dd81
Added toggle control to set any image as feature image if no feature …
up1512001 ca98208
Select Mode: Hide tool selector in the post editor and force design m…
youknowriad e2be79e
Delay block hydration to allow stores to initialize (#66772)
westonruter 69047c3
Bump plugin version to 19.6.0
gutenbergplugin 6f267e8
Update Changelog for 19.6.0
gutenbergplugin 52ba1ab
Post Content: Add border and spacing support (#66366)
rinkalpagdar 51279c8
Global styles revisions: move focus and active state to list item (#6…
ramonjd 922fa39
Block Gap: Fix block spacing control for axial gap supported blocks (…
aaronrobertshaw 9101b04
Group the storybook components in feedback category (#66660)
hbhalodia 8561db1
Revert "Set image width to `fit-content` to solve aspect ratio proble…
kevin940726 802d16c
Feat: Storybook: Improve component organisation - Navigation Category…
hbhalodia 8d2da44
Relocate “View” external link to end of editor header controls (#66785)
ntsekouras 781db89
ESLint: Fix React Compiler violations in various commands (#66787)
tyxla c799c8d
Fix inconsistent sidebars close buttons sizes (#66756)
afercia 7c1df17
Iframe: always enable for block themes, in core too (#66800)
ellatrix 386825b
Data: Rename useSelect internals to fix React Compiler violations (#6…
tyxla 9ffdabb
Block Editor: Fix React Compiler error for 'BlockProps' util (#66809)
Mamaduka 2e1d891
Enable zoom out mode for non-iframe editor (#66789)
t-hamano c57c222
Core Commands: Fix add new post URL assignment (#66830)
tyxla 7177582
Iframe: Fix relative wp-content URLs (#66751)
Soean da17c5a
Process Block Type: Copy deprecation to a new object instead of mutat…
andrewserong d3727c7
Image: Add `aria-haspopup` prop write mode `more` tools menu items (#…
ntsekouras d707df7
adds anchor support in details block (#66734)
amitraj2203 5dea0f9
Block Editor: Fix stale dependencies of selectors depending on editor…
mcsf 34b1847
Update Commands docs with the existing contexts (#66860)
ntsekouras b60f9bd
Remove unnecessary boolean assignments (#66857)
ntsekouras 04c6670
update: Add Media to Add media in cover block (#66835)
up1512001 2c75b8f
Bump plugin version to 19.6.1
gutenbergplugin 6a184eb
Update Changelog for 19.6.1
gutenbergplugin 9436bcb
Fix flash when clicking template name in the editor when a plugin reg…
Aljullu d846bc7
Update placeholder text for blocks that support drag and drop (#66842)
matiasbenedetto 56bf068
Add 6.6.2 to Version in WordPress (#66870)
benniledl 255b3de
Popover: Fix missing label of the headerTitle Close button. (#66813)
afercia 3b6b604
Style book:reduce margin selector specificity to avoid overriding glo…
ramonjd ba5f803
Inserter: Add 'Starter Content' category to the inserter (#66819)
ellatrix d3e4e83
Fix TypeError when duplicating uncategorized theme patterns (#66889)
carolinan d49bdd8
Revert: Fix unable to remove empty blocks on merge (#65262) + alterna…
ellatrix 0a1b5a9
Safari: prevent focus capturing caused by flex display (#66402)
ellatrix 164c669
Add a landing section to stylebook tabs (#66545)
tellthemachines 21c1d28
Section Styles: Fix insecure properties removal for inner block types…
aaronrobertshaw 7eade84
Cover: Show DropZone only when dragging withing the block (#66912)
ntsekouras 258164d
DataViews Fields API: default getValueFromId supports nested objects …
oandregal 28cd670
DataViews: Implement `isItemClickable` and `onClickItem` props (#66365)
gigitux 519c776
Site Editor: Avoid using edited post selectors in welcome guide (#66926)
youknowriad b2c6192
Media & Text: Set `.wp-block-media-text__media a` display to block (#…
Infinite-Null 37b5b55
Interactivity API: fix property modification from inherited context t…
DAreRodz 2bacb50
Post fields: move `status` from `edit-site` to `fields` package (#66937)
oandregal 5625cf1
Post fields: clean up (#66941)
oandregal 2844f0e
Post fields: move `comment_status` from `edit-site` to `fields` packa…
oandregal a318a45
Storybook: Improve component organisation - Actions (#66680)
Vrishabhsk 77c53f3
Feat: Storybook: Improve component organisation - Overlays Category -…
hbhalodia a47617d
Feat: Storybook: Improve component organisation - Typography - Issue …
hbhalodia 4327388
Media: add `x-wav` mime type for wav files in Firefox (#66850)
ramonjd 210a770
Media: check for `wav` mime type using isset (#66947)
ramonjd 99c91bc
Style Updates
karthick-murugan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A border will change the sizing of the image. I believe we have a mixin or variable that uses the box-shadow for the focus style instead. Also, I think we should apply the focus style to the button, not the inner part of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback @jeryj When I try to add box-shadow I can see the outline on the right side and bottom only and cannot see it in top and left. This is because the Site Icon is on the Top Left. Please have a look at this screenshot
Please advice how to proceed in this case. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeryj if you have some time, please advice on this. Thanks in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to apply the focus ring to a
:beforeor:afterpseudo element in order to have it be visible and inset slightly from the edge.