Fix components coding standards in Zoom Out Toolbar #65858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
getdave
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: -4 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks @MaggieCabrera 🙇 Waiting on a 👍 from @ciampo to make sure he's happy with the implementation then we'll 🚢 |
ciampo
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
But this PR still uses CSS to apply the "next" button size.
Why?
Because AFAIK, we can't do this via props as the components utilising the buttons are shared with other toolbars and I want to avoid prop drilling.
I see. Prop drilling isn't the way. At the same time, a style override isn't the way either. The changes in the current PR are definitely an improvement over what's on trunk (thank you, @getdave ❤️ ) — and I believe we should merge it.
But I also believe that we can do better. This version of the toolbar should be discussed and spec'd at the design level first. Are we settled on this being a variant of the toolbar that we'd like to use going forward? If so, we should build this in the toolbar itself.
(cc @WordPress/gutenberg-design )
I'm not confident that it will remain as a standard UI element no. There's still talk of reverting to a standard toolbar in For that reason I don't see huge value in over optimising for this use case now. If it turns out to be a stable component by the time we get to 6.8 then we could revisit this. What do you think? |
|
I'm going to enable auto-merge on this one as an improvement over what is in |
|
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk. |
|
Whoops. I missed #63994. I'll do this manually next week. |
noisysocks
added
Backported to WP Core
|
Don't worry @getdave I got you. |
noisysocks
pushed a commit
that referenced
this pull request
Oct 6, 2024
See #63994 (comment) Co-authored-by: getdave <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: ciampo <[email protected]>
|
Thanks @noisysocks 👍 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
See WordPress#63994 (comment) Co-authored-by: getdave <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: ciampo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #63994 (comment)
What?
Avoids targetting
components-*classes.Addresses review in #63994 (comment)
Why?
See #63994 (comment)
How?
I read this line from the review:
But this PR still uses CSS to apply the "next" button size.
Why?
Because AFAIK, we can't do this via props as the components utilising the buttons are shared with other toolbars and I want to avoid prop drilling.
Testing Instructions
trunkactivate Zoom Out and select a section.Testing Instructions for Keyboard
Screenshots or screencast
Before
After