Block bindings: Fix useSelect hook returns different values, being same objects with different references. #65245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -17 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
cbravobernal
changed the title
The 'useSelect' hook returns different values when called with the same state and parameters.
cbravobernal
changed the title
The 'useSelect' hook returns different values when called with the same state and parameters.
cbravobernal
added
[Type] Bug
|
If I am not mistaken, not including I've made a commit in the original pull request that I believe addresses this issue. Repro of the mentioned problem with this code:
With the code from this pull request useSelect.PR.mp4With the code from the commit in the original PR useSelect.commit.mp4 |
|
Let's close it in favor on just using the empty object const. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove useSelect warning, as commented in #64072 (review)
Leaving it as a draft, as still I don't know if I'm messing this solution.