Rich text: refactor placeholder #64941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Aug 30, 2024
| @@ -28,7 +22,7 @@ | |||
|
|
|||
| // Captions may have lighter (gray) text, or be shown on a range of different background luminosites. | |||
| // To ensure legibility, we increase the default placeholder opacity to ensure contrast. | |||
| figcaption.block-editor-rich-text__editable [data-rich-text-placeholder]::before { | |||
There was a problem hiding this comment.
This was actually broken, so maybe I should just remove it. It was using ::before...
|
Size Change: -279 B (-0.02%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use the :empty selector with a fallback.
Why?
It's simpler. Additionally iOS does not like the current placeholder and fails to autocapitalise sentences. It's not entirely fixed with this, but it's one of the causes.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast