Remove pattern explorer modal #63636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -594 B (-0.03%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dd786ef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9963257102
|
stokesman
reviewed
Jul 17, 2024
|
Iirc this modal used to be the only way to retrieve patterns from the directory. But since that's no longer the case it does feel a bit duplicative. I'd be interested to hear @richtabor's thoughts. |
jeryj
commented
Jul 17, 2024
Comment on lines
-21
to
-27
| // This is derived from the top padding set on | ||
| // `.block-editor-block-patterns-explorer__list` | ||
| scroll-margin-top: $grid-unit-30; | ||
| // This is derived from the bottom padding set on | ||
| // `.block-editor-block-patterns-explorer__list` and | ||
| // the bottom margin set on `...__list-item` above | ||
| scroll-margin-bottom: ($grid-unit-40 + $grid-unit-30); |
There was a problem hiding this comment.
I couldn't get these to apply when viewing the query pattern explorer or the sidebar inserter pattern explorer. None of them had a snapping effect for me.
|
We shouldn't remove this, unless it's clear that people don't use it, and we replace any loss in functionality. As @jameskoster mentioned, it's how search results from the pattern directory can be pulled in. |
|
@richtabor What features are available in the modal that aren't available in the sidebar inserter? |
From what I see the default "All" view is pulling in all the same patterns as when I open the explorer. That agrees with James’s comment #63636 (comment). There doesn’t seem to be an absolute need for the explorer anymore. |
|
Closing as it seems like we're not ready to remove this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the pattern explorer modal from the pattern inserter sidebar.
Why?
The modal is not adding anything not already available in the pattern sidebar. Rather than have an alternate experience (that is not working well:
How?
Remove it, rely on the pattern sidebar in the inserter
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast