Image block: Remove unnecessary variables on expand on click implementation #63290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -25 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dcac079. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9854969909
|
madhusudhand
approved these changes
Jul 10, 2024
cbravobernal
approved these changes
Jul 11, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: luisherranz <[email protected]> Co-authored-by: madhusudhand <[email protected]> Co-authored-by: cbravobernal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I have deleted some unnecessary variables from the implementation of the expand-on-click feature of the image block.
Why?
Because at the time this implementation was done, there was a bug in the Interactivity API: when an element was added to the context or the state, the internal variables of that element tried to become reactive and failed.
That bug was fixed in this pull request, so the variables in this implementation that stored the reference of the button and the reference of the image are no longer needed.
How?
Simply deleting those variables and letting everything be in the context/state.
Testing Instructions