Try: Inspector inner shadow border fix. #63245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.3 kB (+0.07%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Can we also improve the block inserter sidebar shadow? Before.interface-interface-skeleton__secondary-sidebar {
@include break-medium() {
box-shadow: $border-width 0 0 0 rgba($color: #000, $alpha: 0.133);
}
}
After.interface-interface-skeleton__secondary-sidebar {
@include break-medium() {
box-shadow: $border-width $border-width 0 0 rgba($color: #000, $alpha: 0.133);
}
}
|
|
Nice one, works well:
|
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
* Try: Inspector inner shadow border fix. * Apply to inserter as well. Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* Try: Inspector inner shadow border fix. * Apply to inserter as well. Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There's a double-border at the footer of the inspector:
Perhaps not double, but stacked, at least. This is related to changing some of the borders to be shadow based. This PR changes the direction of the shadow, so this stacked shadow disappears:
Note: From reading the code, the 1px
yposition value seemed like it was intentionally added. So I'd love a good look at what side-effects zeroing that out might have. I couldn't find any, but I could be missing a beat.Testing Instructions
Test the site and post editors at various breakpoints, with and without the inspector.