DataViews's filterSortAndPaginate utility: support sorting by number #63187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Enhancement
oandregal
requested review from
youknowriad,
ellatrix,
jorgefilipecosta and
ntsekouras
|
Sorting is another case where having the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
commented
Jul 5, 2024
| @@ -61,7 +61,7 @@ export function filterSortAndPaginate< Item >( | |||
| } ); | |||
| } | |||
|
|
|||
| if ( view.filters.length > 0 ) { | |||
| if ( view.filters?.length > 0 ) { | |||
There was a problem hiding this comment.
We shouldn't require filters presence to be able to process data.
oandregal
changed the title
|
Size Change: +19 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jul 5, 2024
youknowriad
reviewed
Jul 5, 2024
|
|
||
| if ( | ||
| typeof valueA === 'number' && | ||
| typeof valueB === 'number' |
There was a problem hiding this comment.
This ideally should come from the "field" type and not by guessing the value type. Any other words, the "field types" should define a sorting function. But this is more down the road. This is ok for now.
andrewserong
added
the
[Feature] DataViews
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ordPress#63187) Co-authored-by: oandregal <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Adds support for sorting by number to the
filterSortAndPaginateDataViews utility.Why?
DataViews shouldn't be limited to sort by strings.
How?
Implement sorting by number.
Testing Instructions
Verify tests pass.