Compose: Fix 'useFocusOnMount' cleanup callback #62053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
youknowriad,
afercia and
tyxla
and removed request for
ajitbohra
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
May 28, 2024
tyxla
approved these changes
May 28, 2024
| }, [] ); | ||
|
|
||
| return useCallback( ( node ) => { | ||
| return useRefEffect( ( node ) => { |
|
Thanks for the review! In React 19, we should be able to use |
Mamaduka
added
the
props-bot
github-actions
bot
removed
the
props-bot
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a bug in
useFocusOnMountthat prevented it from moving the focus to the first element in StrictMode environments.The bug was discovered via #61943.
Why?
The effects ran one extra time in StrictMode, and the extra call was removing the scheduled timer callback.
How?
Swap
useCallbackwithuseRefEffectand move the cleanup callback.Testing Instructions
Patch for enabling modes
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-05-28.at.14.09.20.mp4