More block: Fix React warning when adding custom text #61936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
reviewed
May 24, 2024
| @@ -10,7 +10,7 @@ import { getDefaultBlockName, createBlock } from '@wordpress/blocks'; | |||
| const DEFAULT_TEXT = __( 'Read more' ); | |||
|
|
|||
| export default function MoreEdit( { | |||
| attributes: { customText, noTeaser }, | |||
| attributes: { customText = '', noTeaser }, | |||
There was a problem hiding this comment.
Should we add a default to the attribute definition? I think that's what a lot of blocks do
There was a problem hiding this comment.
Sometimes, attribute updates require deprecations. I think undefined values don't get serialized, while empty does.
I can double-check, but adding deprecation for a simple fix like this is probably not worth it. What do you think?
There was a problem hiding this comment.
@ellatrix, I was wrong. It looks like there's no need for deprecation, at least for the current case.
|
Size Change: -4 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 52e3144. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9222375264
|
ellatrix
approved these changes
May 24, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes a React warning triggered by the "More" block when updating the placeholder text.
Why?
This can happen when the value changes from
undefinedto other primitive values like string.How?
Set the default value to an empty string instead of
undefined.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast