-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: The focus styles for tabPanel. #61317
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @vipul0425! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
@WordPress/gutenberg-components Can you please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Could you merge or rebase this PR onto current trunk
and add a changelog for this as a bug fix please? Then we can merge 🚀
Hi, @mirka Updated the changelog and merged |
…ss#61317) * fix: The focus styles for tabPanel. * Docs: Update the changelog. Co-authored-by: vipul0425 <[email protected]> Co-authored-by: mirka <[email protected]>
…ss#61317) * fix: The focus styles for tabPanel. * Docs: Update the changelog. Co-authored-by: vipul0425 <[email protected]> Co-authored-by: mirka <[email protected]>
What?
Fixes #60663
When a tab panel is focused, the focus ring styles differ from those of the Tabs component. The main distinctions lie in the color and outline width, as no styles are added for the tab items, and user agent styles are applicable to them.
Why?
This PR resolves the inconsistency between the focus styles for TabPanel and Tabs component.
How?
This PR adds the box-shadow and outline styles for the class
.components-tab-panel__tab-content
Testing Instructions
Testing Instructions for Keyboard
Nil
Screenshots or screencast
Before
After