Revert "Make sure the CSS class id-dark-theme is added to the editor iframe body. (#60300) #60616
+6
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
requested review from
afercia and
ramonjd
and removed request for
ellatrix
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
glendaviesnz
added
[Type] Bug
|
Size Change: -38 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Can confirm that I'm seeing the follow type error on trunk in Safari
null is not an object (evaluating 'contentDocument.body.classList')
With the branch checked out, that error is gone.
Thanks for the quick fix @glendaviesnz
|
@afercia apologies for the lack of time to consult on this, but there as a tight timeframe to get a fix into 18.1 |
This was referenced Apr 9, 2024
ramonjd
added a commit
that referenced
this pull request
Apr 10, 2024
…iframe body. (#60300)" (#60616) This reverts commit a4ae813. Co-authored-by: glendaviesnz <[email protected]> Co-authored-by: ramonjd <[email protected]>
|
I just cherry-picked this PR to the release/18.1 branch to get it included in the next release: dfec163 |
ramonjd
removed
the
Backport to Gutenberg RC
ellatrix
reviewed
Apr 10, 2024
| // `is-dark-theme` class added by useDarkThemeBodyClassName. | ||
| const initialIframeBodyClasses = Array.from( | ||
| contentDocument.body.classList | ||
| ); |
There was a problem hiding this comment.
Why not just revert this part?
There was a problem hiding this comment.
because .concat( initialIframeBodyClasses ) is not relevant without the above, and is-dark-theme check at this point may also not be relevant, but it can be added back if needed in a follow up PR that gets is-dark-theme working in the post editor, otherwise it seemed like there was potential for it to be left there as dead code.
There was a problem hiding this comment.
If I took your suggestion to "remove all this logic introduced last week" too literally 😄 I can put up a PR to add back in the `|| name === 'is-dark-theme' tomorrow if you think it is worth it.
There was a problem hiding this comment.
18.1 has already been released with the revert. 18.2 will be cut in 2 weeks if it can wait. Thanks!
There was a problem hiding this comment.
yep, I don't believe it will be an urgent change if we do add it back, 18.2 will be fine I think.
@glendaviesnz no worries and thanks for fixing it. Sorry for the inconvenience, it's interesting that this problem only occurred in Safari. I will reopen the original issue as that class is necessary to work properly but it evidently needs a different solution. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This reverts commit a4ae813.
Why?
This commit broke the setting of editor styles in Safari - see #60550 (comment)
How?
Just reverts the commit for 18.1, and an alternative approach for keeping the
is-dark-themecan be researched as a follow upTesting Instructions