Code clean-up: Rename 'reusable blocks' to 'shared blocks' #5996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Status] In Progress
pento
approved these changes
Apr 5, 2018
- s/reusableBlock/sharedBlock/ - s/ReusableBlock/SharedBlock/ - s/reusable-block/shared-block/ - s/reusable_block/shared_block/ - s/REUSABLE_BLOCK/SHARED_BLOCK/ - s/reusable block/shared block/ - s/is-reusable/is-shared/ - s/convertBlockToReusable/convertBlockToShared/ - s/CONVERT_BLOCK_TO_REUSABLE/CONVERT_BLOCK_TO_SHARED/ - Manually replace occurrences of /reusable block/i - Manually rename files that match /reusable/i - Audit all occurrences of /reusable/i
noisysocks
force-pushed
the
update/rename-reusableBlocks-to-sharedBlocks
branch
from
a92352d to
ee1b374
Compare
|
😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #5322, we renamed reusable blocks to shared blocks throughout the UI.
Now that this feature has settled down, it's a good time to perform this change throughout the codebase and rename any function, variable or constant from e.g.
reusableBlocktosharedBlock.This was brought up in #5322 (comment).
To do this, I performed these changes automatically:
I then performed these changes manually:
I then spent two hours trying to get our PHP unit tests to run locally, but that's another story! 🙃
How Has This Been Tested?
First, the automated ought to pass.
Then: