Fix double click to edit text of link #59599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
This makes sense to me and solves the issue. I'd like some more eyes on it though as there could be other considerations I missed. |
alexstine
approved these changes
Mar 5, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Testing this via playground and found an odd "link is empty" notice but otherwise this works well for double click to edit: Screen.Recording.2024-03-05.at.3.30.50.PM.movThe only other point of feedback is that if you click inside a link (UI opens), click another word nearby, then click back again it seems to automatically go to edit rather than showing the UI. I'd expect I'd have to do a proper double click again. |
|
Just tested the branch locally and can replicate the same issue as Anne -
I'll also note that I tested the button block which has a similar interaction (you click on linked text and the link popover shows up) but the popover doesn't get focus like it does with the paragraph and heading block. Probably outside the scope of this issue, but the inconsistent behavior could probably be addressed in a separate issue. |
The Link UI on other blocks will need to be handled separately as you suggest. |
|
Closing in favour of #59635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59525
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-03-05.at.15-08-52.1.mp4