Search block - File block: Add deprecated vars to render_callback functions
#58432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Code Quality
3 tasks
|
To be honest, I think this PR is not needed because if third-parties were using these functions with more arguments and they are still passing them, it won't break, it's just that the arguments won't be used which is totally fine. So IMO, we should just close this PR but would love input from @desrosj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In last Interactivity API changes, we added-removed the three variables that are passed through the render_callback.
As these functions may be have been used by external developers, we need to "deprecate them", but only in the docs.
_deprecated_argumentis not being used, cause if it is added, it will appear in all blocks rendered, as the callback is always passing those values (even if they are not being used)Doing this:
Would cause this:
So the cleanest way to deal with this issue is to leave the variables, skip the linting issue, and add them as deprecated in the docs.