Site editor: reduce artificial loading delay from 1s to 100ms #57953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
So looking at #50222, it sounds like we should be able to reduce this number as the editor loads faster in JS, since the requests made by blocks should get made more quickly. |
youknowriad
approved these changes
Jan 18, 2024
|
I would love to know how to test so we can tweak it further. @tyxla? |
|
Thanks, @ellatrix! Back in the day, we did add 1s with the intent to try reducing it at some point (see this commit). I'm glad that as editor performance generally improved, we were able to reduce this so much. |
|
I'm going to give it a spin now FWIW, haven't tested it yet. Will report back, since it's been a while since I worked on this. |
|
Works well in my tests. Thanks again! |
|
@tyxla Could you share how you're testing this? :) |
|
I'm just loading the site editor ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
1 second is way too much in my opinion to be artificially delaying loading of the site editor. Note that this is a delay that happens after all requests are resolved, so everyone is waiting 1 second longer than needed, making the site editor feel unnecessarily slow. 100ms should probably be enough the capture the brief moments between a request resolving and a request starting.
It's also unclear which pauses between which requests this is supposed to address. Where does the delay come from? Are all requests not started at the same time?
First introduced by #50222.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast