Preferences modal: fix the position of sticky heading when blocks are hidden #55456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.66 MB ℹ️ View Unchanged
|
jameskoster
approved these changes
Oct 19, 2023
|
Thanks for the review, @jameskoster!
Does this mean that you are expecting something like the following?
|
|
Probably an informational notice (blue) rather than a warning (yellow), but yes something like that. It's definitely not something to prioritise, or to add to this PR. Just a general observation of something we might address later in a separate PR. |
|
Understood! Now, I would like to merge this PR and consider responding as a follow-up 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #52248
What?
This PR fixes the misalignment of the fixed header when the blocks are hidden in the preferences modal of the Post Editor.
Why?
We should have also considered the message displayed when the block is hidden.
How?
Similar to #52248, I shifted the message and header when the block is hidden by 4px. Also, I'm using variables rather than hard-coded values.
Testing Instructions
Screenshots or screencast
725335ed190c9fa31a26d49723bc8d2a.mp4